inspector: Move JS API code to separate file#16056
Closed
eugeneo wants to merge 1 commit intonodejs:masterfrom
eugeneo:js_api
Closed
inspector: Move JS API code to separate file#16056eugeneo wants to merge 1 commit intonodejs:masterfrom eugeneo:js_api
eugeneo wants to merge 1 commit intonodejs:masterfrom
eugeneo:js_api
Conversation
nodejs-github-bot
added
c++
addaleax
approved these changes
Oct 7, 2017
Contributor
Author
TimothyGu
approved these changes
Oct 9, 2017
Contributor
Author
|
CI shows some compilation issues on some platforms - I will fix them. |
Contributor
Author
|
Included New CI: https://ci.nodejs.org/job/node-test-pull-request/10543/ |
Contributor
Author
jasnell
pushed a commit
that referenced
this pull request
Oct 13, 2017
PR-URL: #16056 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 4faa231 |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#16056 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
PR-URL: #16056 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
inspector: refactored
This refactoring moves all the code supporting inspector JS APIs to a separate file. The reason for this is to make it easier to navigate the inspector_agent.js file (also this should force better C++ API for inspector agent). Debug signal handling code also does not belong to inspector_agent.cc file, but that will be refactored in a separate change.