test: remove error messages from async-hooks-promise#16022
Closed
asfourco wants to merge 1 commit intonodejs:masterfrom
asfourco:async-hooks-promise-test_error_messages
Closed
test: remove error messages from async-hooks-promise#16022asfourco wants to merge 1 commit intonodejs:masterfrom asfourco:async-hooks-promise-test_error_messages
asfourco wants to merge 1 commit intonodejs:masterfrom
asfourco:async-hooks-promise-test_error_messages
Conversation
nodejs-github-bot
added
addons
BridgeAR
approved these changes
Oct 6, 2017
Trott
added
the
code-and-learn
Member
|
Why are these removed? |
cjihrig
approved these changes
Oct 7, 2017
Member
|
@benjamingr ... the code-and-learn exercise was focused on removing or improving the assert error messages (removing so that the often times more helpful default message is displayed) |
Member
Member
|
CI will need to be re-run for this. It's not running any subtasks. |
Member
Member
|
CI failures look unrelated. Landed in 5ea88b7, thanks! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 14, 2017
PR-URL: #16022 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#16022 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #16022 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test