http2: use common.fixtures.fixturesDir in 304 tests#15839
Closed
klmarsh4 wants to merge 2 commits intonodejs:masterfrom
Closed
http2: use common.fixtures.fixturesDir in 304 tests#15839klmarsh4 wants to merge 2 commits intonodejs:masterfrom
klmarsh4 wants to merge 2 commits intonodejs:masterfrom
Conversation
klmarsh4
changed the title
rmg
approved these changes
Oct 6, 2017
Contributor
rmg
left a comment
rmg
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the contribution!
Trott
added
the
code-and-learn
gibfahn
reviewed
Oct 6, 2017
Member
There was a problem hiding this comment.
You should be able to use fixtures.path('elipses.txt') rather than the path.resolve(...), which would be even nicer. If you could push a new commit to your branch to add this change that'd be ideal.
Not mandatory though.
See the docs for more info: https://github.com/nodejs/node/blob/master/test/common/README.md#fixturespathargs
Author
There was a problem hiding this comment.
Oh, cool. Thanks for the heads up. I'll try and get a new commit up as soon as I get the chance.
gibfahn
approved these changes
Oct 6, 2017
benjamingr
approved these changes
Oct 7, 2017
gireeshpunathil
approved these changes
Oct 10, 2017
Member
gireeshpunathil
left a comment
gireeshpunathil
left a comment
There was a problem hiding this comment.
LGTM upon addressing @gibfahn 's change request.
added 2 commits
October 10, 2017 18:42
There is a helper function to do the path merging, so it makes sense to use it
klmarsh4
force-pushed
the
test-http2-respond-file-304-fixturesDir-replace
branch
from
4604273 to
66a9fca
Compare
lpinca
approved these changes
Oct 11, 2017
Member
gireeshpunathil
pushed a commit
that referenced
this pull request
Oct 12, 2017
PR-URL: #15839 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in 6b5433d. Thanks for the contribution! |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#15839 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15839 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15839 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace common.fixturesDir with common.fixtures.fixturesDir
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2