nodejs · danbev · Mar 24, 2017 · Mar 24, 2017 · May 9, 2017 · May 18, 2017
diff --git a/.eslintrc.yaml b/.eslintrc.yaml
@@ -62,6 +62,9 @@ rules:
   no-delete-var: 2
   no-undef: 2
   no-unused-vars: [2, {args: none}]
+  no-use-before-define: [2, {classes: true,
+                             functions: false,
+                             variables: false}]
 
   # Node.js and CommonJS
   # http://eslint.org/docs/rules/#nodejs-and-commonjs

diff --git a/README.md b/README.md
@@ -240,6 +240,8 @@ more information about the governance of the Node.js project, see
 
 * [abouthiroppy](https://github.com/abouthiroppy) -
 **Yuta Hiroto** &lt;[email protected]&gt; (he/him)
+* [addaleax](https://github.com/addaleax) -
+**Anna Henningsen** &lt;[email protected]&gt; (she/her)
 * [ak239](https://github.com/ak239) -
 **Aleksei Koziatinskii** &lt;[email protected]&gt;
 * [andrasq](https://github.com/andrasq) -
@@ -256,12 +258,20 @@ more information about the governance of the Node.js project, see
 **Benjamin Gruenbaum** &lt;[email protected]&gt;
 * [bmeck](https://github.com/bmeck) -
 **Bradley Farias** &lt;[email protected]&gt;
+* [bnoordhuis](https://github.com/bnoordhuis) -
+**Ben Noordhuis** &lt;[email protected]&gt;
 * [brendanashworth](https://github.com/brendanashworth) -
 **Brendan Ashworth** &lt;[email protected]&gt;
 * [bzoz](https://github.com/bzoz) -
 **Bartosz Sosnowski** &lt;[email protected]&gt;
 * [calvinmetcalf](https://github.com/calvinmetcalf) -
 **Calvin Metcalf** &lt;[email protected]&gt;
+* [ChALkeR](https://github.com/ChALkeR) -
+**Сковорода Никита Андреевич** &lt;[email protected]&gt; (he/him)
+* [chrisdickinson](https://github.com/chrisdickinson) -
+**Chris Dickinson** &lt;[email protected]&gt;
+* [cjihrig](https://github.com/cjihrig) -
+**Colin Ihrig** &lt;[email protected]&gt;
 * [claudiorodriguez](https://github.com/claudiorodriguez) -
 **Claudio Rodriguez** &lt;[email protected]&gt;
 * [danbev](https://github.com/danbev) -
@@ -276,22 +286,36 @@ more information about the governance of the Node.js project, see
 **Alexander Makarenko** &lt;[email protected]&gt;
 * [eugeneo](https://github.com/eugeneo) -
 **Eugene Ostroukhov** &lt;[email protected]&gt;
+* [evanlucas](https://github.com/evanlucas) -
+**Evan Lucas** &lt;[email protected]&gt; (he/him)
+* [fhinkel](https://github.com/fhinkel) -
+**Franziska Hinkelmann** &lt;[email protected]&gt;
 * [firedfox](https://github.com/firedfox) -
 **Daniel Wang** &lt;[email protected]&gt;
+* [Fishrock123](https://github.com/Fishrock123) -
+**Jeremiah Senkpiel** &lt;[email protected]&gt;
 * [geek](https://github.com/geek) -
 **Wyatt Preul** &lt;[email protected]&gt;
 * [gibfahn](https://github.com/gibfahn) -
 **Gibson Fahnestock** &lt;[email protected]&gt; (he/him)
+* [gireeshpunathil](https://github.com/gireeshpunathil) -
+**Gireesh Punathil** &lt;[email protected]&gt; (he/him)
 * [iarna](https://github.com/iarna) -
 **Rebecca Turner** &lt;[email protected]&gt;
 * [imran-iq](https://github.com/imran-iq) -
 **Imran Iqbal** &lt;[email protected]&gt;
 * [imyller](https://github.com/imyller) -
 **Ilkka Myller** &lt;[email protected]&gt;
+* [indutny](https://github.com/indutny) -
+**Fedor Indutny** &lt;[email protected]&gt;
+* [isaacs](https://github.com/isaacs) -
+**Isaac Z. Schlueter** &lt;[email protected]&gt;
 * [italoacasas](https://github.com/italoacasas) -
 **Italo A. Casas** &lt;[email protected]&gt; (he/him)
 * [JacksonTian](https://github.com/JacksonTian) -
 **Jackson Tian** &lt;[email protected]&gt;
+* [jasnell](https://github.com/jasnell) -
+**James M Snell** &lt;[email protected]&gt; (he/him)
 * [jasongin](https://github.com/jasongin) -
 **Jason Ginchereau** &lt;[email protected]&gt;
 * [jbergstroem](https://github.com/jbergstroem) -
@@ -304,6 +328,8 @@ more information about the governance of the Node.js project, see
 **João Reis** &lt;[email protected]&gt;
 * [joshgav](https://github.com/joshgav) -
 **Josh Gavant** &lt;[email protected]&gt;
+* [joyeecheung](https://github.com/joyeecheung) -
+**Joyee Cheung** &lt;[email protected]&gt; (she/her)
 * [julianduque](https://github.com/julianduque) -
 **Julian Duque** &lt;[email protected]&gt; (he/him)
 * [JungMinu](https://github.com/JungMinu) -
@@ -322,22 +348,38 @@ more information about the governance of the Node.js project, see
 **Aleksey Smolenchuk** &lt;[email protected]&gt;
 * [matthewloring](https://github.com/matthewloring) -
 **Matthew Loring** &lt;[email protected]&gt;
+* [mcollina](https://github.com/mcollina) -
+**Matteo Collina** &lt;[email protected]&gt; (he/him)
+* [mhdawson](https://github.com/mhdawson) -
+**Michael Dawson** &lt;[email protected]&gt; (he/him)
 * [micnic](https://github.com/micnic) -
 **Nicu Micleușanu** &lt;[email protected]&gt; (he/him)
 * [mikeal](https://github.com/mikeal) -
 **Mikeal Rogers** &lt;[email protected]&gt;
+* [misterdjules](https://github.com/misterdjules) -
+**Julien Gilli** &lt;[email protected]&gt;
 * [monsanto](https://github.com/monsanto) -
 **Christopher Monsanto** &lt;[email protected]&gt;
+* [mscdex](https://github.com/mscdex) -
+**Brian White** &lt;[email protected]&gt;
+* [MylesBorins](https://github.com/MylesBorins) -
+**Myles Borins** &lt;[email protected]&gt; (he/him)
 * [not-an-aardvark](https://github.com/not-an-aardvark) -
 **Teddy Katz** &lt;[email protected]&gt;
+* [ofrobots](https://github.com/ofrobots) -
+**Ali Ijaz Sheikh** &lt;[email protected]&gt;
 * [Olegas](https://github.com/Olegas) -
 **Oleg Elifantiev** &lt;[email protected]&gt;
+* [orangemocha](https://github.com/orangemocha) -
+**Alexis Campailla** &lt;[email protected]&gt;
 * [othiym23](https://github.com/othiym23) -
 **Forrest L Norvell** &lt;[email protected]&gt; (he/him)
 * [petkaantonov](https://github.com/petkaantonov) -
 **Petka Antonov** &lt;[email protected]&gt;
 * [phillipj](https://github.com/phillipj) -
 **Phillip Johnsen** &lt;[email protected]&gt;
+* [piscisaureus](https://github.com/piscisaureus) -
+**Bert Belder** &lt;[email protected]&gt;
 * [pmq20](https://github.com/pmq20) -
 **Minqi Pan** &lt;[email protected]&gt;
 * [princejwesley](https://github.com/princejwesley) -
@@ -360,6 +402,8 @@ more information about the governance of the Node.js project, see
 **Ron Korving** &lt;[email protected]&gt;
 * [RReverser](https://github.com/RReverser) -
 **Ingvar Stepanyan** &lt;[email protected]&gt;
+* [rvagg](https://github.com/rvagg) -
+**Rod Vagg** &lt;[email protected]&gt;
 * [saghul](https://github.com/saghul) -
 **Saúl Ibarra Corretgé** &lt;[email protected]&gt;
 * [sam-github](https://github.com/sam-github) -
@@ -368,14 +412,20 @@ more information about the governance of the Node.js project, see
 **Santiago Gimeno** &lt;[email protected]&gt;
 * [seishun](https://github.com/seishun) -
 **Nikolai Vavilov** &lt;[email protected]&gt;
+* [shigeki](https://github.com/shigeki) -
+**Shigeki Ohtsu** &lt;[email protected]&gt; (he/him)
 * [silverwind](https://github.com/silverwind) -
 **Roman Reiss** &lt;[email protected]&gt;
 * [srl295](https://github.com/srl295) -
 **Steven R Loomis** &lt;[email protected]&gt;
 * [stefanmb](https://github.com/stefanmb) -
 **Stefan Budeanu** &lt;[email protected]&gt;
+* [targos](https://github.com/targos) -
+**Michaël Zasso** &lt;[email protected]&gt; (he/him)
 * [tellnes](https://github.com/tellnes) -
 **Christian Tellnes** &lt;[email protected]&gt;
+* [thefourtheye](https://github.com/thefourtheye) -
+**Sakthipriyan Vairamani** &lt;[email protected]&gt; (he/him)
 * [thekemkid](https://github.com/thekemkid) -
 **Glen Keane** &lt;[email protected]&gt; (he/him)
 * [thlorenz](https://github.com/thlorenz) -
@@ -384,6 +434,10 @@ more information about the governance of the Node.js project, see
 **Timothy Gu** &lt;[email protected]&gt; (he/him)
 * [tniessen](https://github.com/tniessen) -
 **Tobias Nießen** &lt;[email protected]&gt;
+* [trevnorris](https://github.com/trevnorris) -
+**Trevor Norris** &lt;[email protected]&gt;
+* [Trott](https://github.com/Trott) -
+**Rich Trott** &lt;[email protected]&gt; (he/him)
 * [tunniclm](https://github.com/tunniclm) -
 **Mike Tunnicliffe** &lt;[email protected]&gt;
 * [vkurchatkin](https://github.com/vkurchatkin) -
@@ -399,9 +453,8 @@ more information about the governance of the Node.js project, see
 * [yosuke-furukawa](https://github.com/yosuke-furukawa) -
 **Yosuke Furukawa** &lt;[email protected]&gt;
 
-Collaborators (which includes CTC members) follow the
-[COLLABORATOR_GUIDE.md](./COLLABORATOR_GUIDE.md) in maintaining the Node.js
-project.
+Collaborators follow the [COLLABORATOR_GUIDE.md](./COLLABORATOR_GUIDE.md) in
+maintaining the Node.js project.
 
 ### Release Team
 

diff --git a/configure b/configure
@@ -40,6 +40,7 @@ import nodedownload
 # imports in tools/
 sys.path.insert(0, os.path.join(root_dir, 'tools'))
 import getmoduleversion
+from gyp_node import run_gyp
 
 # parse our options
 parser = optparse.OptionParser()
@@ -972,7 +973,10 @@ def configure_openssl(o):
     ]
   else:
     o['variables']['openssl_fips'] = ''
-
+    try:
+      os.remove('config_fips.gypi')
+    except OSError:
+      pass
 
   if options.without_ssl:
     def without_ssl_error(option):
@@ -1370,7 +1374,7 @@ config = '\n'.join(map('='.join, config.iteritems())) + '\n'
 
 write('config.mk', do_not_edit + config)
 
-gyp_args = [sys.executable, 'tools/gyp_node.py', '--no-parallel']
+gyp_args = ['--no-parallel']
 
 if options.use_xcode:
   gyp_args += ['-f', 'xcode']
@@ -1389,4 +1393,4 @@ gyp_args += args
 if warn.warned:
   warn('warnings were emitted in the configure phase')
 
-sys.exit(subprocess.call(gyp_args))
+run_gyp(gyp_args)
diff --git a/deps/v8/include/v8-version.h b/deps/v8/include/v8-version.h
@@ -11,7 +11,7 @@
 #define V8_MAJOR_VERSION 5
 #define V8_MINOR_VERSION 1
 #define V8_BUILD_NUMBER 281
-#define V8_PATCH_LEVEL 104
+#define V8_PATCH_LEVEL 105
 
 // Use 1 for candidates and 0 otherwise.
 // (Boolean macro values are not supported by all preprocessors.)

diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h
@@ -6869,6 +6869,11 @@ class V8_EXPORT TryCatch {
    */
   void SetVerbose(bool value);
 
+  /**
+   * Returns true if verbosity is enabled.
+   */
+  bool IsVerbose() const;
+
   /**
    * Set whether or not this TryCatch should capture a Message object
    * which holds source information about where the exception

diff --git a/deps/v8/src/api.cc b/deps/v8/src/api.cc
@@ -2395,6 +2395,10 @@ void v8::TryCatch::SetVerbose(bool value) {
   is_verbose_ = value;
 }
 
+bool v8::TryCatch::IsVerbose() const {
+  return is_verbose_;
+}
+
 
 void v8::TryCatch::SetCaptureMessage(bool value) {
   capture_message_ = value;

diff --git a/doc/api/child_process.md b/doc/api/child_process.md
@@ -408,7 +408,7 @@ grep.on('close', (code) => {
 ```
 
 
-Example of checking for failed exec:
+Example of checking for failed `spawn`:
 
 ```js
 const spawn = require('child_process').spawn;

diff --git a/doc/api/cli.md b/doc/api/cli.md
@@ -359,7 +359,7 @@ added: v6.11.0
 
 Load an OpenSSL configuration file on startup. Among other uses, this can be
 used to enable FIPS-compliant crypto if Node.js is built with `./configure
-\-\-openssl\-fips`.
+--openssl-fips`.
 
 If the [`--openssl-config`][] command line option is used, the environment
 variable is ignored.

diff --git a/doc/api/console.md b/doc/api/console.md
@@ -227,9 +227,7 @@ console.log('count:', count);
 // Prints: count: 5, to stdout
 ```
 
-If formatting elements (e.g. `%d`) are not found in the first string then
-[`util.inspect()`][] is called on each argument and the resulting string
-values are concatenated. See [`util.format()`][] for more information.
+See [`util.format()`][] for more information.
 
 ### console.time(label)
 <!-- YAML

diff --git a/doc/api/fs.md b/doc/api/fs.md
@@ -979,6 +979,9 @@ added: v0.4.2
 Change the file timestamps of a file referenced by the supplied file
 descriptor.
 
+*Note*: This function does not work on AIX versions before 7.1, it will return
+the error `UV_ENOSYS`.
+
 ## fs.futimesSync(fd, atime, mtime)
 <!-- YAML
 added: v0.4.2

diff --git a/doc/api/path.md b/doc/api/path.md
@@ -447,7 +447,7 @@ path.relative('C:\\orandea\\test\\aaa', 'C:\\orandea\\impl\\bbb');
 // Returns: '..\\..\\impl\\bbb'
 ```
 
-A [`TypeError`][] is thrown if neither `from` nor `to` is a string.
+A [`TypeError`][] is thrown if either `from` or `to` is not a string.
 
 ## path.resolve([...paths])
 <!-- YAML

diff --git a/doc/api/stream.md b/doc/api/stream.md
@@ -2060,6 +2060,7 @@ readable buffer so there is nothing for a user to consume.
 [HTTP responses, on the server]: http.html#http_class_http_serverresponse
 [http-incoming-message]: http.html#http_class_http_incomingmessage
 [Readable]: #stream_class_stream_readable
+[zlib]: zlib.html
 [stream-_flush]: #stream_transform_flush_callback
 [stream-_read]: #stream_readable_read_size_1
 [stream-_transform]: #stream_transform_transform_chunk_encoding_callback

diff --git a/doc/api/util.md b/doc/api/util.md
@@ -116,16 +116,17 @@ util.format('%s:%s', 'foo');
 // Returns: 'foo:%s'
 ```
 
-If there are more arguments passed to the `util.format()` method than the
-number of placeholders, the extra arguments are coerced into strings (for
-objects and symbols, `util.inspect()` is used) then concatenated to the
-returned string, each delimited by a space.
+If there are more arguments passed to the `util.format()` method than the number
+of placeholders, the extra arguments are coerced into strings then concatenated
+to the returned string, each delimited by a space. Excessive arguments whose
+`typeof` is `'object'` or `'symbol'` (except `null`) will be transformed by
+`util.inspect()`.
 
 ```js
 util.format('%s:%s', 'foo', 'bar', 'baz'); // 'foo:bar baz'
 ```
 
-If the first argument is not a format string then `util.format()` returns
+If the first argument is not a string then `util.format()` returns
 a string that is the concatenation of all arguments separated by spaces.
 Each argument is converted to a string using `util.inspect()`.
 

diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md
@@ -6,6 +6,7 @@
 | --- | --- |
 | `benchmark/*` | @nodejs/benchmarking, @mscdex |
 | `bootstrap_node.js` | @fishrock123 |
+| `doc/*`, `*.md` | @nodejs/documentation |
 | `lib/assert` | @nodejs/testing |
 | `lib/buffer` | @nodejs/buffer |
 | `lib/child_process` | @bnoordhuis, @cjihrig |

diff --git a/lib/_debugger.js b/lib/_debugger.js
@@ -993,7 +993,8 @@ Interface.prototype.debugEval = function(code, context, filename, callback) {
     return;
   }
 
-  var frame = client.currentFrame === NO_FRAME ? frame : undefined;
+  var frame = client.currentFrame;
+  if (frame !== NO_FRAME) frame = undefined;
 
   self.pause();
 

diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
@@ -402,7 +402,7 @@ TLSSocket.prototype._init = function(socket, wrap) {
 
   // lib/net.js expect this value to be non-zero if write hasn't been flushed
   // immediately
-  // TODO(indutny): rewise this solution, it might be 1 before handshake and
+  // TODO(indutny): revise this solution, it might be 1 before handshake and
   // represent real writeQueueSize during regular writes.
   ssl.writeQueueSize = 1;
 
@@ -705,7 +705,7 @@ TLSSocket.prototype.getProtocol = function() {
 // outcomes:
 //
 //   A) verifyError returns null meaning the client's certificate is signed
-//   by one of the server's CAs. The server know's the client idenity now
+//   by one of the server's CAs. The server now knows the client's identity
 //   and the client is authorized.
 //
 //   B) For some reason the client's certificate is not acceptable -
@@ -984,7 +984,7 @@ function normalizeConnectArgs(listArgs) {
   var cb = args[1];
 
   // If args[0] was options, then normalize dealt with it.
-  // If args[0] is port, or args[0], args[1]  is host,port, we need to
+  // If args[0] is port, or args[0], args[1] is host, port, we need to
   // find the options and merge them in, normalize's options has only
   // the host/port/path args that it knows about, not the tls options.
   // This means that options.host overrides a host arg.

diff --git a/lib/buffer.js b/lib/buffer.js
@@ -58,7 +58,7 @@ function alignPool() {
 }
 
 /**
- * The Buffer() construtor is "soft deprecated" ... that is, it is deprecated
+ * The Buffer() constructor is "soft deprecated" ... that is, it is deprecated
  * in the documentation and should not be used moving forward. Rather,
  * developers should use one of the three new factory APIs: Buffer.from(),
  * Buffer.allocUnsafe() or Buffer.alloc() based on their specific needs. There
@@ -124,7 +124,7 @@ Buffer.alloc = function(size, fill, encoding) {
     // Since we are filling anyway, don't zero fill initially.
     // Only pay attention to encoding if it's a string. This
     // prevents accidentally sending in a number that would
-    // be interpretted as a start offset.
+    // be interpreted as a start offset.
     if (typeof encoding !== 'string')
       encoding = undefined;
     return createUnsafeBuffer(size).fill(fill, encoding);
-Original file line number
+Diff line change
@@ Expand Up / @@ -408,7 +408,7 @@ grep.on('close', (code) => { @@
     ```
-    Example of checking for failed exec:
+    Example of checking for failed `spawn`:
     ```js
     const spawn = require('child_process').spawn;
@@ Expand Down @@