http2: handful of http2 src cleanups #14825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Aug 14, 2017
src/node_http2_core.h
Outdated
| } | ||
| } | ||
|
|
||
| #define SESSION_TYPE_NAME(session) SessionTypeName(session->session_type_) |
There was a problem hiding this comment.
Why not just make this a method on Nghttp2Session? That seems easier, plus it avoids needing a #define
(If you want to stick with the define: Parentheses around session ;))
The functions remaining in node_http2_core can be inlined. Do so and eliminate the node_http2_core.cc file entirely.
show server name type rather than number for more useful and clear debug messages
jasnell
force-pushed
the
http2-cleanups
branch
from
40826be to
cdaef97
Compare
jasnell
added a commit
that referenced
this pull request
Aug 16, 2017
* inline more stuff. remove a node_http2_core.cc * clean up debug messages * simplify options code, and cleanup PR-URL: #14825 Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in 949aec5 |
MSLaguana
pushed a commit
to nodejs/node-chakracore
that referenced
this pull request
Aug 21, 2017
* inline more stuff. remove a node_http2_core.cc * clean up debug messages * simplify options code, and cleanup PR-URL: nodejs/node#14825 Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
* inline more stuff. remove a node_http2_core.cc * clean up debug messages * simplify options code, and cleanup PR-URL: #14825 Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
* inline more stuff. remove a node_http2_core.cc * clean up debug messages * simplify options code, and cleanup PR-URL: #14825 Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2