Skip to content

src: allow --tls-cipher-list in NODE_OPTIONS #13172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2017
Merged

src: allow --tls-cipher-list in NODE_OPTIONS #13172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/api/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,7 @@ Node options that are allowed are:
- `--redirect-warnings`
- `--require`, `-r`
- `--throw-deprecation`
- `--tls-cipher-list`
- `--trace-deprecation`
- `--trace-events-categories`
- `--trace-events-enabled`
Expand Down
3 changes: 2 additions & 1 deletion src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3712,7 +3712,7 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
size_t arglen = eq ? eq - arg : strlen(arg);

static const char* whitelist[] = {
// Node options
// Node options, sorted in `node --help` order for ease of comparison.
"--require", "-r",
"--inspect",
"--inspect-brk",
Expand All @@ -3730,6 +3730,7 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
"--track-heap-objects",
"--zero-fill-buffers",
"--v8-pool-size",
"--tls-cipher-list",
"--use-bundled-ca",
"--use-openssl-ca",
"--enable-fips",
Expand Down