src: use std::list for at_exit_functions #12255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
bnoordhuis
requested changes
Apr 6, 2017
src/node.cc
Outdated
| void (*cb_)(void* arg); | ||
| void* arg_; | ||
| }; | ||
|
|
||
| static AtExitCallback* at_exit_functions_; | ||
| static std::list<AtExitCallback*> at_exit_functions_; |
There was a problem hiding this comment.
Use AtExitCallback not a pointer-to-AtExitCallback. It's leaking memory now in RunAtExit().
(Tiny nit: it should really be called at_exit_functions, it's not a class member.)
src/node.cc
Outdated
| p->cb_(p->arg_); | ||
| delete p; | ||
| p = q; | ||
| for (AtExitCallback* atExit : at_exit_functions_) { |
bnoordhuis
approved these changes
Apr 6, 2017
bnoordhuis
reviewed
Apr 6, 2017
src/node.cc
Outdated
| p->cb_ = cb; | ||
| p->arg_ = arg; | ||
| at_exit_functions_.push_back(p); | ||
| AtExitCallback p = {cb, arg}; |
There was a problem hiding this comment.
Oh, maybe call this at_exit for consistency.
There was a problem hiding this comment.
Ah good point, will change that. Thanks!
There was a problem hiding this comment.
Is using an anonymous object something considered ok to do?
at_exit_functions.push_back(AtExitCallback{cb, arg});
2 tasks
richardlau
approved these changes
Apr 6, 2017
cjihrig
approved these changes
Apr 6, 2017
addaleax
approved these changes
Apr 9, 2017
This change was suggested by bnoordhuis in the following comment: nodejs#9163 (comment) Not including any tests as this is covered by test/addons/at-exit.
danbev
added a commit
to danbev/node
that referenced
this pull request
Apr 10, 2017
This change was suggested by bnoordhuis in the following comment: nodejs#9163 (comment) Not including any tests as this is covered by test/addons/at-exit. PR-URL: nodejs#12255 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in fe016c6 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
This change was suggested by bnoordhuis in the following comment: nodejs#9163 (comment) Not including any tests as this is covered by test/addons/at-exit. PR-URL: nodejs#12255 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Should this be cherry-picked to v6.x? It lands cleanly fwiw |
|
@MylesBorins Not sure as it is a minor improvement, but if it lands cleanly I see no harm in that. Let me know if you'd like me to create a PR against v6.x-staging. Thanks |
MylesBorins
pushed a commit
that referenced
this pull request
May 15, 2017
This change was suggested by bnoordhuis in the following comment: #9163 (comment) Not including any tests as this is covered by test/addons/at-exit. PR-URL: #12255 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
This change was suggested by bnoordhuis in the following comment: nodejs/node#9163 (comment) Not including any tests as this is covered by test/addons/at-exit. PR-URL: nodejs/node#12255 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was suggested by bnoordhuis in the following comment:
#9163 (comment)
Not including any tests as this is covered by test/addons/at-exit.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src