test: add regex to assert in test_cyclic_link_protection

[clarenced]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

test

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/6633/

[clarenced]

@Trott Any idea how to fix the failing tests ?

[Trott]

@clarenced It looks like you've uncovered a small bug in the test! Aggravating as that may be to you, I say: Well done! Let's fix it!

The problem is that line 209 on your test is asserting on Windows. Here's line 209:

assert.strictEqual(err.path, entry);

If we look at the error output, we see that err.path is this:

c:\workspace\node-test-binary-windows\RUN_SUBSET\3\VS_VERSION\vcbt2015\label\win10\test\tmp.0\cycles\realpath-3a

...while entry is this:

c:\workspace\node-test-binary-windows\RUN_SUBSET\3\VS_VERSION\vcbt2015\label\win10\test\tmp.0/cycles/realpath-3a

If you scroll all the way to the right on the entry value, you'll see that it stops using the Windows separator \ and starts using the POSIX separator /! Whoops!

This is a bug in the test but we only found it because you made the test more strict!

To fix this, you need to take things like line 194:

const entry = common.tmpDir + '/cycles/realpath-3a';

...and fix them up to use path so that separators get normalized:

const entry = path.join(common.tmpDir, '/cycles/realpath-3a');

(path.join() is smart enough to treat / as a separator in input, even on Windows so the above could should be fine.)

Basically, anywhere that strings with / are being joined together as paths using +, you need to replace it with path.join().

Sorry about this change being a bit more work than I realized when I suggested it! Still, I think this is totally do-able. Thanks for sticking with it!

[clarenced]

Hi @Trott, I am trying to push my modifications on my branch, but I have an error

To https://github.com/clarenced/node.git
 ! [rejected]        test_11498 -> test_11498 (non-fast-forward)
error: failed to push some refs to 'https://github.com/USERNAME/REPOSITORY.git'
To prevent you from losing history, non-fast-forward updates were rejected
Merge the remote changes (e.g. 'git pull') before pushing again.  See the
'Note about fast-forwards' section of 'git push --help' for details.

Should I do a pull --rebase before pushing?

[addaleax]

@clarenced I guess you git commit --amended your changes or did something like that?

In any case, you should be able to push using git push --force-with-lease :)

[clarenced]

Hi @Trott I have the changes as suggested, is there anything else to do ?

[addaleax]

New CI: https://ci.nodejs.org/job/node-test-commit/8343/

[Trott]

LGTM! Thanks for doing this!

[addaleax]

Landed in 7a4adb5! 🎉 Thanks for doing this!

[MylesBorins]

This uses api's that don't exist in v6.x

Please manually backport or add do-not-land label