-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Closed
Labels
punycodeIssues and PRs related to the punycode module bundled in Node.js.Issues and PRs related to the punycode module bundled in Node.js.
Description
- Version: latest
- Platform: any
- Subsystem: punycode
lib/punycode.js
looks more like the dependency required by the core module url
, which is a third party library, and the current source file lib/punycode.js is not that same style with other source files.
So I propose the following:
- add a deps directory in
./lib
directory, so we can put the punycode.js there and load it just like what we are doing except for the source path. (Recommend) - update the punycode source file to be the CMD way just like other
.js
files, this also needs us to add tests and maintainer for this little module even though we are just moving them from the punycode.js project.
Metadata
Metadata
Assignees
Labels
punycodeIssues and PRs related to the punycode module bundled in Node.js.Issues and PRs related to the punycode module bundled in Node.js.