Skip to content

punycode: remove the module system detection from punycode.js #7401

@yorkie

Description

@yorkie
  • Version: latest
  • Platform: any
  • Subsystem: punycode

lib/punycode.js looks more like the dependency required by the core module url, which is a third party library, and the current source file lib/punycode.js is not that same style with other source files.

So I propose the following:

  • add a deps directory in ./lib directory, so we can put the punycode.js there and load it just like what we are doing except for the source path. (Recommend)
  • update the punycode source file to be the CMD way just like other .js files, this also needs us to add tests and maintainer for this little module even though we are just moving them from the punycode.js project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    punycodeIssues and PRs related to the punycode module bundled in Node.js.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions