http.request sends non-standard Host header when IP6 address + port is used

[himdel]

When using the object form of http.request and using an IPv6 address as a hostname, and using a non-standard port, the Host header is created incorrectly...

Example code:

http.request({
  method: 'GET',
  hostname: '::1',
  port:'3000',
  path: '/api',
}, (res) => { console.log(res.statusCode, res.body); })
.end()

This triggers a HTTP request with:

GET /api HTTP/1.1
Host: ::1:3000

Compared to (for example) curl http://[::1]:3000/api, which does

GET /api HTTP/1.1
Host: [::1]:3000

For reference: https://tools.ietf.org/html/rfc7230#section-5.4

• Kudos to @mpotra for helping me debug this issue..

[mpotra]

RFC that defines IPv6 hostnames in URIs: https://tools.ietf.org/html/rfc3986#section-3.2.2

[vkurchatkin]

What happens if you set hostname to [::1]?

[himdel]

@vkurchatkin it tries to resolve it as a hostname (triggers dns) and fails

[vkurchatkin]

Interesting. So rfc3986 says:

A host identified by an Internet Protocol literal address, version 6
[RFC3513] or later, is distinguished by enclosing the IP literal
within square brackets ("[" and "]").

So we just need a good enough way to detect if host is an ipv6 literal

[vkurchatkin]

I think checking for : is enough, since the only reason square brackets are used is to separate port's : from host's.

[jasnell]

The fix landed for this.