File names in readable_stream folder are not supported in Windows

[kunalspathak]

If I clone nodejs/master and do git status git complains bunch of files are added/deleted. The reason is 76cb81b added files in readable_stream with names that are not allowed in Windows. When git clones the repo, it silently renames it. Can we fix that sooner so git is clean when they fetch new contents from nodejs/master?

I could fix it if i know what are the right names of these files.

[fs](x86chk) E:\git>git clone https://github.com/nodejs/node.git deletethis
Cloning into 'deletethis'...
remote: Counting objects: 199414, done.
remote: Compressing objects: 100% (25/25), done.
remote: Total 199414 (delta 12), reused 0 (delta 0), pack-reused 199389
Receiving objects: 100% (199414/199414), 170.71 MiB | 30.25 MiB/s, done.
Resolving deltas: 100% (146367/146367), done.
Checking connectivity... done.
Checking out files: 100% (16833/16833), done.

[fs](x86chk) E:\git>cd E:\git\deletethis\deps\npm\node_modules\readable-stream

[deletethis/master](x86chk) E:\git\deletethis\deps\npm\node_modules\readable-stream>git status .
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        deleted:    .npmignore~8d21794... deps: upgrade npm to 3.6.0
        deleted:    LICENSE~8d21794... deps: upgrade npm to 3.6.0
        deleted:    LICENSE~8d21794... deps: upgrade npm to 3.6.0_0
        deleted:    duplex.js~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/core-util-is/README.md~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/core-util-is/float.patch~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/core-util-is/lib/util.js~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/isarray/README.md~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/isarray/component.json~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/isarray/index.js~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/string_decoder/.npmignore~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/string_decoder/LICENSE~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/string_decoder/README.md~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/string_decoder/index.js~8d21794... deps: upgrade npm to 3.6.0
        deleted:    passthrough.js~8d21794... deps: upgrade npm to 3.6.0
        deleted:    transform.js~8d21794... deps: upgrade npm to 3.6.0
        deleted:    writable.js~8d21794... deps: upgrade npm to 3.6.0

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        .npmignore~8d21794... deps
        LICENSE~8d21794... deps
        duplex.js~8d21794... deps
        node_modules/core-util-is/README.md~8d21794... deps
        node_modules/core-util-is/float.patch~8d21794... deps
        node_modules/core-util-is/lib/util.js~8d21794... deps
        node_modules/isarray/README.md~8d21794... deps
        node_modules/isarray/component.json~8d21794... deps
        node_modules/isarray/index.js~8d21794... deps
        node_modules/string_decoder/.npmignore~8d21794... deps
        node_modules/string_decoder/LICENSE~8d21794... deps
        node_modules/string_decoder/README.md~8d21794... deps
        node_modules/string_decoder/index.js~8d21794... deps
        passthrough.js~8d21794... deps
        transform.js~8d21794... deps
        writable.js~8d21794... deps

[mscdex]

/cc @iarna @zkat

[mscdex]

I can confirm this as well. Although I get errors during clone even:

Cloning into 'deletethis'...
remote: Counting objects: 199429, done.
remote: Compressing objects: 100% (4/4), done.
Receiving objects: 100% (199429/199429), 170.83 MiB | 212.00 KiB/s, done.eiving objects: 100% (199429/199429), 170.81 MiB | 216.00 KiB/s

Resolving deltas: 100% (146377/146377), done.
Checking connectivity... done.
error: Invalid path 'deps/npm/node_modules/readable-stream/.npmignore~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/LICENSE~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/LICENSE~8d21794... deps: upgrade npm to 3.6.0_0'
error: Invalid path 'deps/npm/node_modules/readable-stream/duplex.js~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/core-util-is/README.md~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/core-util-is/float.patch~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/core-util-is/lib/util.js~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/isarray/README.md~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/isarray/component.json~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/isarray/index.js~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/string_decoder/.npmignore~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/string_decoder/LICENSE~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/string_decoder/README.md~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/string_decoder/index.js~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/passthrough.js~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/transform.js~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/writable.js~8d21794... deps: upgrade npm to 3.6.0'
Checking out files: 100% (16816/16816), done.

[janRucka]

The same issue for me when syncing chromium (for nw.js).

[pajoma]

Same issue here. Trying to use NPM in windows (through the Gradle plugin), but the build scripts fail due to the invalid file names in the tar.gz

[ChALkeR]

/cc @nodejs/npm

[JoeDoyle23]

It looks like this specific issue has been resolved. I was able to clone the repo and all of the files had proper names. Is there still a need for a broader fix in case this type of issue happens again?