AIX fs watch improvements

[mhdawson]

Currently the AIX fs watch implementation requires some prior configuration and is not necessarily straight forward to use on AIX.

This issue is to track work to improve the implementation or better document to make it easier to use.

Currently the following tests fail in the CI due to fs watch not being configured:

https://ci.nodejs.org/job/node-test-commit-aix/33/nodes=aix61-ppc64/console

not ok 4 test-async-wrap-check-providers.js
# fs.js:1329
#     throw error;
#     ^
# 
# Error: watch /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-async-wrap-check-providers.js ENOSYS
#     at exports._errnoException (util.js:859:11)
#     at FSWatcher.start (fs.js:1327:19)
#     at Object.fs.watch (fs.js:1355:11)
#     at Object. (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-async-wrap-check-providers.js:38:4)
#     at Module._compile (module.js:417:34)
#     at Object.Module._extensions..js (module.js:426:10)
#     at Module.load (module.js:357:32)
#     at Function.Module._load (module.js:314:12)
#     at Function.Module.runMain (module.js:451:10)
#     at startup (node.js:139:18)
  ---
  duration_ms: 0.448

not ok 4 test-async-wrap-check-providers.js
# fs.js:1329
#     throw error;
#     ^
# 
# Error: watch /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-async-wrap-check-providers.js ENOSYS
#     at exports._errnoException (util.js:859:11)
#     at FSWatcher.start (fs.js:1327:19)
#     at Object.fs.watch (fs.js:1355:11)
#     at Object. (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-async-wrap-check-providers.js:38:4)
#     at Module._compile (module.js:417:34)
#     at Object.Module._extensions..js (module.js:426:10)
#     at Module.load (module.js:357:32)
#     at Function.Module._load (module.js:314:12)
#     at Function.Module.runMain (module.js:451:10)
#     at startup (node.js:139:18)
  ---
  duration_ms: 0.448

not ok 980 test-fs-watch.js
# assert.js:324
#     throw actual;
#     ^
# 
# Error: watch /home/iojs/node-tmp/tmp.0/watch.txt ENOSYS
#     at exports._errnoException (util.js:859:11)
#     at FSWatcher.start (fs.js:1327:19)
#     at Object.fs.watch (fs.js:1355:11)
#     at /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/sequential/test-fs-watch.js:41:24
#     at Function._throws (assert.js:306:5)
#     at Function.assert.doesNotThrow (assert.js:337:11)
#     at Object. (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/sequential/test-fs-watch.js:39:8)
#     at Module._compile (module.js:417:34)
#     at Object.Module._extensions..js (module.js:426:10)
#     at Module.load (module.js:357:32)
  ---
  duration_ms: 1.147
  ...

The short term plan will be to exclude these to get the CI to a green state while we work in parallel on the resolution

• So we don't forget before we close this we need to revert test: disable fs watch tests for AIX #5187 including re-enabling the tests and undoing the change to test/parallel/test-async-wrap-check-providers.js

[mhdawson]

PR to disabled the fs watch tests on AIX until we get this resolved. #5187

[mhdawson]

So we don't forget before we close this we need to revert #5187 including re-enabling the tests and undoing the change to test/parallel/test-async-wrap-check-providers.js

[mhdawson]

Some progress here: libuv/libuv#776