-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
Closed
Labels
v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.
Description
I'm getting a loader error when trying to load a binary extension built with NodeJS 16.0.0 headers on NodeJS 16.6.0:
node: symbol lookup error: /home/runner/work/STT/STT/node_modules/stt/lib/binding/v0.10.0-alpha.11/linux-x64/node-v93/stt.node: undefined symbol: _ZN2v816FunctionTemplate14SetCallHandlerEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEENS_5LocalIS2_EENS_14SideEffectTypeEPKNS_9CFunctionE
Which is v8::FunctionTemplate::SetCallHandler(void (*)(v8::FunctionCallbackInfo<v8::Value> const&), v8::Local<v8::Value>, v8::SideEffectType, v8::CFunction const*)
.
Looking at blame in v8, it looks like this is the relevant commit, which changed the last parameter from a v8::CFunction const pointer to an std::vector of CFunction const pointers: v8/v8@a7980d4
Apologies if this is not the correct place to raise this, but it seemed like the most close to the root cause, specially given that it looks to me like NodeJS 16.6.0 was released with an unplanned ABI breakage.
Originally posted by @reuben in #39470 (comment)
reuben
Metadata
Metadata
Assignees
Labels
v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.