Memory Leak on v16.0.0-pre

[luhuaipei]

The pss/rss of the heap in /proc/pid/smaps will increase about 52k every time when I execute following code:
Please help to figure it out.

Thanks.

function newDate(){                                                              
    sysTime = new Date().toLocaleTimeString('en-US')                             
}                                                                                
                                                                                 
setInterval(newDate, 1000);   

And when I remove the parameter "en-US" of toLocaleTimeString, the program doesn't leak.

[bl-ue]

This should be moved to https://github.com/nodejs/node (ping @Trott)

[Ayase-252]

Does the issue happened on v16.3.0 or master(v17.0.0-pre)?

[luhuaipei]

@Ayase-252 Hi

Here is the test result:
tag v14.17.0 NG
tag v15.14.0 NG
v16. 0. 0 OK
v16. 3. 0 OK

[Ayase-252]

Here is the test result:
tag v14.17.0 NG
tag v15.14.0 NG
v16. 0. 0 OK
v16. 3. 0 OK

@luhuaipei
So... it looks fixed in v16. I suspect that #38178 fixed the issue since it is the only ICU-related change in v16.0.0 release and it will be release in v14.17.1 soon. You could try at that time.

[luhuaipei]

@Ayase-252 Thanks. I cherry-picked the patch to my local, the issue still exists. Do you have other suggestions?

[Ayase-252]

@luhuaipei Sorry, I don't have a clue now.

cc @nodejs/i18n-api

[luhuaipei]

It seems the issue resides in v8. I use the d8 tool in V8(version 8.8.6) can reproduce this issue.

In d8 console, every time I execute

new Date().toLocaleTimeString('en-US')

The Rss section will increase by 52-56Kb.

[targos]

@nodejs/v8

[luhuaipei]

v8/v8@4b139f7

This patch indroduced the fix in v8 version(8.9.1)

[gengjiawen]

v8/v8@4b139f7

This patch indroduced the fix in v8 version(8.9.1)

@gsathya Can you take a look ?