-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
Closed
Labels
confirmed-bugIssues with confirmed bugs.Issues with confirmed bugs.libuvIssues and PRs related to the libuv dependency or the uv binding.Issues and PRs related to the libuv dependency or the uv binding.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Description
- 12.14.0 -- latest version:
- Window 10:
- Subsystem:
What steps will reproduce the bug?
- windows 7/8/10
- set pc's name to
ANDREW-ü-LAPTOP
- make sure 'Use unicode UTF-8 support' is not enable in windows language setting
- in node CLI, invoke os.hostname(), it returns
ANDREW-�-LAPTOP
How often does it reproduce? Is there a required condition?
Always happen.
What is the expected behavior?
ANDREW-ü-LAPTOP
What do you see instead?
ANDREW-�-LAPTOP
Additional information
the fix of #27848 would work fine on linux/macOs. But on windows, libuv's implement does not decoding the string which return be windows API, which cause this bug.
Metadata
Metadata
Assignees
Labels
confirmed-bugIssues with confirmed bugs.Issues with confirmed bugs.libuvIssues and PRs related to the libuv dependency or the uv binding.Issues and PRs related to the libuv dependency or the uv binding.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.