-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
Closed
Labels
async_hooksIssues and PRs related to the async hooks subsystem.Issues and PRs related to the async hooks subsystem.node-apiIssues and PRs related to the Node-API.Issues and PRs related to the Node-API.
Description
Maybe we should also think about adapting napi_async_init
as it states that the resource is optional. As Node is meanwhile built to require an async resource it seems to be strange that we create an object on the fly if user doesn't provide one.
Removing the null check in napi_async_init
would be no issue from ABI point of view but breaking from behavior. Not sure if this should be included in this PR.
Metadata
Metadata
Assignees
Labels
async_hooksIssues and PRs related to the async hooks subsystem.Issues and PRs related to the async hooks subsystem.node-apiIssues and PRs related to the Node-API.Issues and PRs related to the Node-API.