V8 tests failing on v12.16.0+

[mmarchini]

• Version: v12.16.0+
• Platform: Linux
• Subsystem: v8

What steps will reproduce the bug?

Checkout to v12.16.0, build V8 and run tests:

# assume depot_tools is present in PATH
$ cd deps/v8
$ ./tools/node/fetch_deps.py .
$ ./tools/dev/v8gen.py x64.release --no-goma
$ ninja -C out.gn/x64.release d8 cctest inspector-test
$ ./tools/run-tests.py --gn --arch=x64 --mode=release mjsunit cctest debugger inspector message preparser

How often does it reproduce? Is there a required condition?

Every time, when the test is around 40%

What is the expected behavior?

Test should succeed

What do you see instead?

=== cctest/test-bytecode-generator/PrivateAccessorAccess ===
<unknown>:53: Uncaught TypeError: '#b' was defined without a setter
<unknown>:46: Uncaught TypeError: '#c' was defined without a getter
<unknown>:61: Uncaught TypeError: '#d' was defined without a setter
<unknown>:46: Uncaught TypeError: '#e' was defined without a getter
Generated has extra lines after line 182
  Generated: ''


#
# Fatal error in , line 0
# Check failed: CompareTexts(BuildActual(printer, snippets), LoadGolden("PrivateAccessorAccess.golden")).
#
#
#
#FailureMessage Object: 0x7ffd00953e00
==== C stack trace ===============================

    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x25da7c3) [0x55a4995fd7c3]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x25d9efb) [0x55a4995fcefb]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x2485f25) [0x55a4994a8f25]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x10b12b5) [0x55a4980d42b5]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0xf70257) [0x55a497f93257]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0xf710c4) [0x55a497f940c4]
    /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7) [0x7f555468cb97]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(_start+0x2a) [0x55a497f9302a]
Aborted (core dumped)
Command: out.gn/x64.release/cctest test-bytecode-generator/PrivateAccessorAccess --random-seed=-257712540 --nohard-abort --testing-d8-test-runner
=== cctest/test-bytecode-generator/PrivateAccessorDeclaration ===
Generated has extra lines after line 389
  Generated: ''


#
# Fatal error in , line 0
# Check failed: CompareTexts(BuildActual(printer, snippets), LoadGolden("PrivateAccessorDeclaration.golden")).
#
#
#
#FailureMessage Object: 0x7ffdab840c00
==== C stack trace ===============================

    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x25da7c3) [0x563cd31937c3]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x25d9efb) [0x563cd3192efb]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x2485f25) [0x563cd303ef25]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x10b1556) [0x563cd1c6a556]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0xf70257) [0x563cd1b29257]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0xf710c4) [0x563cd1b2a0c4]
    /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7) [0x7fcd2b6d2b97]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(_start+0x2a) [0x563cd1b2902a]
Aborted (core dumped)
Command: out.gn/x64.release/cctest test-bytecode-generator/PrivateAccessorDeclaration --random-seed=-257712540 --nohard-abort --testing-d8-test-runner
=== cctest/test-bytecode-generator/PrivateMethodDeclaration ===
Generated has extra lines after line 189
  Generated: ''


#
# Fatal error in , line 0
# Check failed: CompareTexts(BuildActual(printer, snippets), LoadGolden("PrivateMethodDeclaration.golden")).
#
#
#
#FailureMessage Object: 0x7ffc4d638510
==== C stack trace ===============================

    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x25da7c3) [0x56186f51f7c3]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x25d9efb) [0x56186f51eefb]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x2485f25) [0x56186f3caf25]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x10b0d42) [0x56186dff5d42]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0xf70257) [0x56186deb5257]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0xf710c4) [0x56186deb60c4]
    /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7) [0x7fefa22fcb97]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(_start+0x2a) [0x56186deb502a]
Aborted (core dumped)
Command: out.gn/x64.release/cctest test-bytecode-generator/PrivateMethodDeclaration --random-seed=-257712540 --nohard-abort --testing-d8-test-runner
=== cctest/test-bytecode-generator/PrivateMethodAccess ===
<unknown>:57: Uncaught TypeError: Private method '#b' is not writable
<unknown>:49: Uncaught TypeError: Private method '#c' is not writable
Generated has extra lines after line 94
  Generated: ''


#
# Fatal error in , line 0
# Check failed: CompareTexts(BuildActual(printer, snippets), LoadGolden("PrivateMethodAccess.golden")).
#
#
#
#FailureMessage Object: 0x7fff3b6568a0
==== C stack trace ===============================

    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x25da7c3) [0x5612a3ee97c3]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x25d9efb) [0x5612a3ee8efb]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x2485f25) [0x5612a3d94f25]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0x10b0fd8) [0x5612a29bffd8]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0xf70257) [0x5612a287f257]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(+0xf710c4) [0x5612a28800c4]
    /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7) [0x7fad22216b97]
    /home/mmarchini/workspace/nodejs/node-v12.x-backport-f7771e5b0cc4/deps/v8/out.gn/x64.release/cctest(_start+0x2a) [0x5612a287f02a]
Aborted (core dumped)
Command: out.gn/x64.release/cctest test-bytecode-generator/PrivateMethodAccess --random-seed=-257712540 --nohard-abort --testing-d8-test-runner

Additional information

git bisect points to 35f2892. Not sure we can fix it though. Opening the issue anyway so folks backporting V8 commits to v12 can find the error message.

[addaleax]

@mmarchini Just for context, these failures have been noticed in the V8 CI runs before, but we agreed to be okay with this because these only affect flagged, experimental features. I agree that there’s not really something we can or should do, unless somebody really wants to dig into these failures.

[mmarchini]

I think those are also whitespace issues because of git node land (similar to what happened recently on master). I'll try to investigate it further.

[MylesBorins]

@mmarchini would you be open to making a backport to 12.x to fix the whitespace issues?

[mmarchini]

If that's the same issue, yes (it'll probably be a fresh PR to v12 instead of a backport though)

[MylesBorins]

Sgtm

…

On Wed, Apr 1, 2020, 5:13 PM Matheus Marchini ***@***.***> wrote: If that's the same issue, yes (it'll probably be a fresh PR to v12 instead of a backport though) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#32076 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADZYV2P2MMBDKKCNEHCHDLRKOVARANCNFSM4LAUL62Q> .

[mmarchini]

Fixed on #32605