Skip to content

Make Http2Session maximum invalid frame count configurable #30505

@lundibundi

Description

@lundibundi

Is your feature request related to a problem? Please describe.
We have flaky #29802 that doesn't hit the needed amount of invalid frames and crashes with OOM which may be solved by decreasing the amount of maximum invalid frames for that test.
It may prove useful for people to be able to configure how many invalid frames they want to tolerate though I don't think it'll be a popular feature.
At the same time, it shouldn't add too much of a maintenance burden to us.

Describe the solution you'd like
Probably option of maxSessionInvalidFrames (comepletely open to better names) to http2.createServer()/http2.createSecureServer() and possibly http2.connect(). I don't think this needs to be changed on the go and can be set upon server creation, though dynamic change may be useful.

Though I'm not sure how to pass that to our C++-land Http2Session? (via js_fields_; property on Http2Session accessible from JS; constructor param?)

Describe alternatives you've considered
None probably, it's hardcoded so it can stay that way.

/cc @addaleax as the one who added invalid frame counting.
/cc @nodejs/http2

Metadata

Metadata

Assignees

No one assigned

    Labels

    discussIssues opened for discussions and feedbacks.feature requestIssues that request new features to be added to Node.js.http2Issues or PRs related to the http2 subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions