-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
Open
Labels
help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.http2Issues or PRs related to the http2 subsystem.Issues or PRs related to the http2 subsystem.
Description
http2 compat is missing writableFinished
for OutgoingMessage
.
I tried fixing this myself but the whole finished flow for http2 compat confuses me.
finished
seems to be looking at a lot of different stuff (e.g. what does abort have to do with finish?).'finish'
is emitted onstream.on('close', ...)
.- Sometimes we listen to
this.on('finish', ...)
and sometimesstream.on('finish', ...)
.
I think someone with a clearer understanding needs to look at this.
Metadata
Metadata
Assignees
Labels
help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.http2Issues or PRs related to the http2 subsystem.Issues or PRs related to the http2 subsystem.