Investigate flaky parallel/test-tls-sni-option

[mscdex]

• Version: master
• Platform: macos
• Subsystem: tls

On osx1011 (test-macstadium-macos10.11-x64-1):

18:54:26 not ok 1968 parallel/test-tls-sni-option
18:54:26   ---
18:54:26   duration_ms: 0.663
18:54:26   severity: fail
18:54:26   exitcode: 1
18:54:26   stack: |-
18:54:26     events.js:171
18:54:26           throw er; // Unhandled 'error' event
18:54:26           ^
18:54:26     
18:54:26     Error: read ECONNRESET
18:54:26         at TLSWrap.onStreamRead (internal/stream_base_commons.js:182:27)
18:54:26     Emitted 'error' event at:
18:54:26         at emitErrorNT (internal/streams/destroy.js:91:8)
18:54:26         at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
18:54:26         at processTicksAndRejections (internal/process/task_queues.js:81:17)

[MylesBorins]

I've been seeing this locally a bunch

[lpinca]

The culprit seems to be this commit: 42dbaed.

Easily reproducible on my machine with:

./tools/test.py -J --repeat=1000 test/parallel/test-tls-sni-option.js

If --node-args=--tls-max-v1.2 is used I can no longer reproduce.

cc: @sam-github

[sam-github]

@lpinca What kind of machine do you have? I can't repro with your test.py invocation, or by running:

while ./out/Release/node test/parallel/test-tls-sni-option.js; do; done;

three times in parallel, on linux x64. That said, this test looks like it depends on the order of completion of the handshakes on client relative to server, I am prepping a PR.

[sam-github]

I read the top in more detail, it's on OS X, I''ll try on that.

[lpinca]

Yes I can't reproduce on Linux, only on macOS.

[lpinca]

The following patch fixes it but I'm not sure why.

diff --git a/test/parallel/test-tls-sni-option.js b/test/parallel/test-tls-sni-option.js
index 3a6a231b47..6ccf631169 100644
--- a/test/parallel/test-tls-sni-option.js
+++ b/test/parallel/test-tls-sni-option.js
@@ -115,7 +115,7 @@ let clientError;
 
 const server = tls.createServer(serverOptions, function(c) {
   serverResults.push({ sni: c.servername, authorized: c.authorized });
-  c.end();
+  // c.end();
 });
 
 server.on('tlsClientError', function(err) {
@@ -137,7 +137,8 @@ function startTest() {
         client.authorizationError &&
          (client.authorizationError === 'ERR_TLS_CERT_ALTNAME_INVALID'));
 
-      next();
+      client.on('close', next);
+      client.end();
     });
 
     client.on('error', function(err) {