Coverage reporting is broken

[BridgeAR]

The coverage report from the last couple of days is broken (see https://coverage.nodejs.org). I guess it's related to the V8 update. It could also be a @nodejs/build issue but I guess the update is more likely.

// cc @bcoe @nodejs/v8-update

[richardlau]

Can't get to my irc logs at the moment, but I did post some initial investigation in #build. It looks like when it started to break that native addons were being compiled at the same time as the main node binary and this was causing an error which caused the makefile to bail out before running all the tests. No idea what cause it to start happening, but the first build where it started was the one containing the update to V8 7.1.

[targos]

If that's what you say, #23982 would probably fix it.

[richardlau]

hmm http://logs.nodejs.org/node-build/index seems to have stopped on 2018-12-01. I'll copy the logs from home when I get there for reference. I have no idea why the regular CI's aren't running into the problem, but I believe (again from irc) that @addaleax and @Trott were seeing it locally.

[Trott]

If that's what you say, #23982 would probably fix it.

I guess the question is if @bnoordhuis's comment is blocking or not.

[Trott]

hmm http://logs.nodejs.org/node-build/index seems to have stopped on 2018-12-01. I'll copy the logs from home when I get there for reference. I have no idea why the regular CI's aren't running into the problem, but I believe (again from irc) that @addaleax and @Trott were seeing it locally.

I was not seeing it locally. I noticed it broken at coverage.nodejs.org. Haven't tested locally, but I can...

Here's my screenshot of #node-build IRC channel:

[bnoordhuis]

I guess the question is if @bnoordhuis's comment is blocking or not.

It is. Wrong is wrong.

http://logs.nodejs.org/node-build/index seems to have stopped on 2018-12-01

I restarted slurp just now.

[BridgeAR]

Good to know that the V8 update broke the addon to compile. I am running into that issue locally at the moment and I could not figure out what was wrong.

[addaleax]

If that's what you say, #23982 would probably fix it.

I don’t think it would do that, because that’s macOS-only thing and the problem that Rich and I were talking about on IRC is giving me significant problems on Linux.

I haven’t debugged this, but it looks like somehow, the Makefile is broken in the following ways:

1. make always triggers a re-compilation of the node binary. This should not happen if make was successfully run before and no changes have been made since.
2. Building test addons does not wait for the node binary to be finished, but still uses it. This leads to a race condition, where building an addon can fail because the binary is currently being linked; 1. makes this problem worse, because now running make -j4 && make -j4 test is not a viable way to work around the problem anymore.

[targos]

If that's what you say, #23982 would probably fix it.

I don’t think it would do that, because that’s macOS-only thing and the problem that Rich and I were talking about on IRC is giving me significant problems on Linux.

It's not a macOS-only thing. That PR fixes the problem for me on Linux. The change actually excludes macOS because it introduces another issue on that platform.

Also, the Makefile was already broken in the same way before the V8 7.1 upgrade. It was just a lot less likely to see it happen because there were less GYP actions executed to build V8.

[BridgeAR]

Does anyone have an idea how to solve this?

[ZYSzys]

So all the recent informations on https://coverage.nodejs.org/ are misleading right ?

[targos]

Maybe that's a candidate for the new pinned issues feature?