-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
Open
Labels
help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.httpsIssues or PRs related to the https subsystem.Issues or PRs related to the https subsystem.
Description
Node version 8.11.3. 64-bit Windows 8.1
As I understood from docs, timeout
property in https.request
options sets socket connection timeout.
I set it to minimum - 1 millisecond and it should definitely trigger 'timeout' event.
const options = {
host: 'yobit.net',
path: '/api/3/depth/ltc_btc',
timeout: 1
}
const req = https.request(options, res => {
});
req.on('timeout', () => {
console.error('request timeout');
})
req.end();
I expect 'reqest timeout' console message but it doen't appear.
However, when I create my custom https Agent with overriden createConnection
method that sets initial socket timeout to 1 millisecond there:
MyAgent.prototype.createConnection = function() {
const socket = https.Agent.prototype.createConnection.apply(this, arguments);
socket.setTimeout(1);
return socket;
}
and run the first code with agent parameter set to my custom agent, now it fires 'timeout' event.
bencevans, swarthy, geekykant and danon
Metadata
Metadata
Assignees
Labels
help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.httpsIssues or PRs related to the https subsystem.Issues or PRs related to the https subsystem.