Windows IRPStackSize increased to pass test-debug-port-from-cmdline.js

[rvagg]

@nodejs/platform-windows

test-debug-port-from-cmdline.js has been failing repeatedly on 2008 like so:

not ok 136 - test-debug-port-from-cmdline.js
#c:\workspace\iojs+pr+win\nodes\win2008r2\test\parallel\test-debug-port-from-cmdline.js:20
#    process._debugProcess(child.pid);
#            ^
#Error: Not enough storage is available to process this command.
#    at Error (native)
#    at ChildProcess.onChildMsg (c:\workspace\iojs+pr+win\nodes\win2008r2\test\parallel\test-debug-port-from-cmdline.js:20:13)
#    at emitTwo (events.js:87:13)
#    at ChildProcess.emit (events.js:172:7)
#    at handleMessage (internal/child_process.js:632:10)
#    at Pipe.channel.onread (internal/child_process.js:421:11)

So I followed the instructions @ https://support.microsoft.com/en-us/kb/106167 and increased IRPStackSize to 9 and now it appears to be passing.

This doesn't seem like an appropriate course of action because we can't advise developers to do this in order to get the test suite to pass. But since I have no idea why this is even required I'm not sure of a better way forward or how to suggest a possible fix.

[benjamingr]

Isn't 9 well below the default value?

On Thu, Jul 2, 2015 at 11:55 AM, Rod Vagg notifications@github.com wrote:

@nodejs/platform-windows
https://github.com/orgs/nodejs/teams/platform-windows

test-debug-port-from-cmdline.js has been failing repeatedly on 2008 like
so:

not ok 136 - test-debug-port-from-cmdline.js
#c:\workspace\iojs+pr+win\nodes\win2008r2\test\parallel\test-debug-port-from-cmdline.js:20

process._debugProcess(child.pid);

^

#Error: Not enough storage is available to process this command.

at Error (native)

at ChildProcess.onChildMsg (c:\workspace\iojs+pr+win\nodes\win2008r2\test\parallel\test-debug-port-from-cmdline.js:20:13)

at emitTwo (events.js:87:13)

at ChildProcess.emit (events.js:172:7)

at handleMessage (internal/child_process.js:632:10)

at Pipe.channel.onread (internal/child_process.js:421:11)

So I followed the instructions @
https://support.microsoft.com/en-us/kb/106167 and increased IRPStackSize
to 9 and now it appears to be passing.

This doesn't seem like an appropriate course of action because we can't
advise developers to do this in order to get the test suite to pass. But
since I have no idea why this is even required I'm not sure of a better way
forward or how to suggest a possible fix.

—
Reply to this email directly or view it on GitHub
#2094.

[rvagg]

I believe 4 is the default when the entry doesn't exist

[benjamingr]

The default value of the IRPStackSize parameter is 15. The range is from 11 (0xb hexadecimal) through 50 (0x32 hexadecimal).

https://support.microsoft.com/en-us/kb/285089

[rvagg]

I see your KB article and raise you mine:

Note Values may range from 0x1 to 0xC. These values are equivalent to 1 to 12 in decimal notation.

If the IRPStackSize registry entry is not present, the computer uses a default value of 0x4.

https://support.microsoft.com/en-us/kb/106167

But then again, it has NT 3.51 at the bottom of the page!

[benjamingr]

But then again, it has NT 3.51 at the bottom of the page!

Haha, yeah, it even links to a different one from NT 4, I wonder what running io.js on any of those would look like. Anyway, I'll try a fresh VM and check.

[benjamingr]

Ok, opened a new Windows Server 2008R2 VM on Azure - it is not defined:

Would it help if I cloned io.js on it and ran the tests?

[rvagg]

Anyone running tests on windows helps! we have too few eyes at the developer level on core code & tests on windows. See https://github.com/nodejs/build/tree/master/setup/windows if you want detailed docs of how we do it.

[benjamingr]

Thanks, I'm already familiar with the procedure :) Any specific branch?

[rvagg]

master is where we're seeing it, also I've upped the 2008 servers to 24 (decimal) now

[benjamingr]

Hmm, on Windows 2008 we can't install VS2013 Express since it requires a newer version of Windows. I'll try with VS2012

[rvagg]

vs2012 isn't going to work, you need Microsoft Visual Studio Express 2013 for Windows Desktop or a prerelease of 2015, we're running on 2008R2 just like your Azure machine, perhaps it's the fact that you're trying Express that's the problem.

[mathiask88]

There is a difference between "Express for windows" and "Express for windows desktop". The last one is compatible with Windows Server 2008 R2 SP1 (x64).

[orangemocha]

You can also use Visual Studio Community Edition. It practically supersedes Express: https://www.visualstudio.com/en-us/products/visual-studio-community-vs.aspx

I just learned about IRPStackSize, but it seems an issue with the specific driver stack on the machine, not a general issue. See this post on the subject: http://forum.sysinternals.com/when-irpstacksize-can-cause-a-problem_topic22059_post116568.html#116568