-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Closed
Labels
confirmed-bugIssues with confirmed bugs.Issues with confirmed bugs.pathIssues and PRs related to the path subsystem.Issues and PRs related to the path subsystem.
Description
I believe #19237 to be the culprit of this change.
I believe that PR unintentionally changed the behaviour of at least path.resolve
which was not documented in the changelog.
We have a specific test around path.resolve
and it started failing after 9.9.0 was released. See https://travis-ci.org/thelounge/thelounge/jobs/356475798#L582
On 9.8.0 this happens:
> require("path").resolve("a\\b")
'/home/xpaw/a\\b'
But on 9.9.0 it seems that separator is changed to the OS specific one.
> require("path").resolve("a\\b")
'/home/xpaw/a/b'
Metadata
Metadata
Assignees
Labels
confirmed-bugIssues with confirmed bugs.Issues with confirmed bugs.pathIssues and PRs related to the path subsystem.Issues and PRs related to the path subsystem.