-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Closed
Labels
docIssues and PRs related to the documentations.Issues and PRs related to the documentations.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.
Description
After working on the v9.5.0 release proposal, I was concerned to see that the node-test-linter ci job failed. Apparently, we are linting docs in CI, but not locally with make lint
.
IMO, if we lint in CI, we should lint locally. Otherwise, people could be confused as to why it passes locally but not when run in CI. Would love to hear the opinions of others
Metadata
Metadata
Assignees
Labels
docIssues and PRs related to the documentations.Issues and PRs related to the documentations.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.