inspector-port=0 edge case crash

[refack]

• Version: 8.1.0
• Platform: *
• Subsystem: cli

after 399cb25 there's an edge case that crashes node

D:\code\node$ Release\node.exe --inspect-port=0
> process.debugPort

D:\code\node$ echo %ERRORLEVEL%
-1073741819

D:\code\node$

[sam-github]

This happens on master as well as 8.x and 8.x-staging

[eugeneo]

I do not see this on Linux and Mac. Other then Windows OS, is there anything else that might be triggering it?

[sam-github]

I only tried it on my laptop (Ubuntu), and it repros for me, and makes sense.

IsStarted() is confusingly named, it is true if the inspector is initialized, even when it doesn't listen. There is only an ->io() after the inspector starts the listening/IO thread, and that doesn't happen with --inspect-port

[sam-github]

And when I back out the fix in #13504, the test in that PR fails.

[eugeneo]

Oh! I didn't notice it was "--inspect-port" and not just "--inspect"

…

On Tue, Jun 6, 2017 at 3:16 PM Sam Roberts ***@***.***> wrote: And when I back out the fix in #13504 <#13504>, the test in that PR fails. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#13499 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARkrdFSi_QpM40bsvHiSP4RisxHNhx_ks5sBc-6gaJpZM4Nxl2P> .