-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Closed
Labels
discussIssues opened for discussions and feedbacks.Issues opened for discussions and feedbacks.docIssues and PRs related to the documentations.Issues and PRs related to the documentations.testIssues and PRs related to the tests.Issues and PRs related to the tests.
Description
In CONTRIBUTING.md
:
You can run tests directly with node: ```text $ ./node ./test/parallel/test-stream2-transform.js ```
This bit is a little problematic and can trip up new folks.
- You can run tests in some directories (such as
parallel
andsequential
) but not others (such asmessage
). - If the test has a
--FLAGS
comment, then that needs to be taken into account on the command line or else the test won't work.
We could clarify all this, or we could just remove that bit of text entirely and instruct people to always use test.py
. That second option seems like the better one to me. Discuss.
@nodejs/testing
Metadata
Metadata
Assignees
Labels
discussIssues opened for discussions and feedbacks.Issues opened for discussions and feedbacks.docIssues and PRs related to the documentations.Issues and PRs related to the documentations.testIssues and PRs related to the tests.Issues and PRs related to the tests.