This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Fixes compile error if configured without ssl#9153
Closed
dmitry-yudakov wants to merge 1 commit intonodejs:masterfrom
Closed
Fixes compile error if configured without ssl#9153dmitry-yudakov wants to merge 1 commit intonodejs:masterfrom
dmitry-yudakov wants to merge 1 commit intonodejs:masterfrom
Conversation
Disables also command line options for ssl in this case.
Member
|
Closing as duplicate of #25862. Can reopen if that is incorrect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If node is configured with --without-ssl node_crypto.h is not included in node.cc,
but variables declared in it are still used - it leads to compile error.
This change disables --enable-ssl2 and --enable-ssl3 options for given configuration.