Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

dns: allow v8 to optimize lookup() #8942

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/dns.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

var cares = process.binding('cares_wrap'),
net = require('net'),
isIp = net.isIP;
isIP = net.isIP;


function errnoException(errorno, syscall) {
Expand Down Expand Up @@ -78,7 +78,9 @@ function makeAsync(callback) {

// Easy DNS A/AAAA look up
// lookup(domain, [family,] callback)
exports.lookup = function(domain, family, callback) {
exports.lookup = function(domain, family_, callback_) {
var family = family_,
callback = callback_;
// parse arguments
if (arguments.length === 2) {
callback = family;
Expand All @@ -102,12 +104,12 @@ exports.lookup = function(domain, family, callback) {
// localhost entry from c:\WINDOWS\system32\drivers\etc\hosts
// See http://daniel.haxx.se/blog/2011/02/21/localhost-hack-on-windows/
// TODO Remove this once c-ares handles this problem.
if (process.platform == 'win32' && domain == 'localhost') {
if (process.platform === 'win32' && domain === 'localhost') {
callback(null, '127.0.0.1', 4);
return {};
}

var matchedFamily = net.isIP(domain);
var matchedFamily = isIP(domain);
if (matchedFamily) {
callback(null, domain, matchedFamily);
return {};
Expand Down