Upgrade OpenSSL to 1.0.1m

[misterdjules]

See the announcement of the upcoming 1.0.1m release.

When the node v0.10.38 release that contains the OpenSSL upgrade is done, please merge into v0.12 and do the v0.12.1 release.

[misterdjules]

@jasnell As discussed this morning, the plan for now is to first upgrade OpenSSL in v0.10, then to merge v0.10 into v0.12.1 branched off of v0.12.0, and finally to merge v0.12.1-release into v0.12.

@joyent/node-coreteam Please let us know if this is correct.

[jasnell]

Sounds good.
On Mar 19, 2015 12:29 PM, "Julien Gilli" notifications@github.com wrote:

@jasnell https://github.com/jasnell As discussed this morning, the plan
for now is to first upgrade OpenSSL in v0.10, then to merge v0.10 into
v0.12.1 branched off of v0.12.0, and finally to merge v0.12.1-release into
v0.12.

@joyent/node-coreteam https://github.com/orgs/joyent/teams/node-coreteam
Please let us know if this is correct.

—
Reply to this email directly or view it on GitHub
#9441 (comment).

[jasnell]

@joyent/node-coreteam ...

For review:
Patch against: v0.10.37-release - jasnell/node@8a917ca (my branch: https://github.com/jasnell/node/tree/v0.10.37-opensslm)

Patch against: v0.12.0-release - jasnell/node@5cc430f (my branch: https://github.com/jasnell/node/tree/v0.12.0-opensslm)

The patch followed the process documented in the io.js openssl-m update (nodejs/node#1206) by @shigeki

Builds on Mac OSx 10.10 and Ubuntu 14.10. Tests pass. Needs additional review and verification.

[shigeki]

I've just reviewed the v0.10.37-opensslm branch and verified there is no difference from my patch. It can work on Node-v0.10.x. LGTM.

[jasnell]

@shigeki ... I appreciate your work. You made it significantly easier for
me 👍
On Mar 19, 2015 7:14 PM, "Shigeki Ohtsu" notifications@github.com wrote:

I've just reviewed the v0.10.37-opensslm branch and verified there is no
difference from my patch. It can work on Node-v0.10.x. LGTM.

—
Reply to this email directly or view it on GitHub
#9441 (comment).

[misterdjules]

@shigeki @jasnell Looking at the changes, I think it would be better to make changes to deps/openssl/openssl.gyp instead of changes to the OpenSSL source itself to work around the symlinked headers. That makes us have to maintain one less floating patch.

I would also like to keep at least these commits:

• shigeki/node@a3e0da2.
• shigeki/node@ac89f8a.

as separate commits so that we can track them separately from the rest of the changes.

How does that sound?

[piscisaureus]

The problem with symlinked headers is that they're a pain on windows.

[jasnell]

See alternate PR: #9451

[shigeki]

@misterdjules It would be possible to move all headers to the directory out of OpenSSL source such as deps/openssl/config/openssl/include/ and change include_dirs in openssl.gyp. But I wonder if there are some addons to use openssl library which refers deps/openssl/openssl/include in their gyp and they are all affected.

[shigeki]

On openssl git repository, the include directory is empty and written in .gitignore. Makefile generates symlinks by using util/mklink.pl. But the distributed tar.gz file includes symlinks and it causes issues on Windows as pointed out by @piscisaureus . So we need to modify the original source so as to make the include directory be empty even when we change to use gyp.