url + http/https: weird api between these module

[yorkie]

url.format will return an object owns pathname rather than path, however http.request and https.request do accept path rather than pathname.

sometimes, we would seem to write our program:

var urlobj = url.format('http://github.com/yorkie');
http.request(urlobj, function (res) {
  // actually we get the response from http://github.com
});

path is missing, yeah actually we can add urlobj.path = urlobj.pathname for now, it does work as well, but it's a weird behavior in api level imo.

I'm guessing we should unify these two/three functions definitely, of course backward compatible with url module.

[yorkie]

sorry, i mean url.format doesn't accept path, the case in real world is https://github.com/yorkie/node-httpmocker/blob/master/index.js#L39.

[yorkie]

any thoughts from core team?

[indutny]

What node.js version are we talking about?

[indutny]

Also, could you please paste a complete example of this thing, i.e. the code that works with http module and doesn't with https.

[yorkie]

From the latest stable docs:

• http(s).request http://nodejs.org/api/http.html#http_http_request_options_callback
• url.format http://nodejs.org/api/url.html#url_url_format_urlobj

the complete example should be written at https://github.com/yorkie/node-httpmocker/blob/master/index.js#L39, now i copy/paste it here:

function mockRequest(options, callback) {
  var requesturl = url.format(options);
  // ...
}

The function mockRequest will be called like http.request or https.request because this function is mocking these 2 official APIs.

Hence that the progress is: calling mockRequest({host: 'github.com', path: '/induty'}) would be equal to url.format({host: 'github.com', path: '/induty'}), and path would be ignored by url.format at that moment. To let example work, we have to add a line: options.pathname = options.path.

To reproduce this on v0.10.33:

> url.format({protocol:'http',host:'github.com',path:'/induty'})
'http://github.com'
> url.format({protocol:'http',host:'github.com',pathname:'/induty'})
'http://github.com/induty'

[yorkie]

and this actually is not related http or https, but never mind, it's not a bug just wanna get thoughts from core team 🌸

[indutny]

Oh, I see. It doesn't look like there could be a reason why it should not support path as well as pathname. Mind submitting a PR with test? ;)

[yorkie]

bingo, then would do that later 🍒

[chrisdickinson]

Fixed in d312b6d.