On Windows in Node 0.11.13 path.resolve causes files to be re-evaluated on second require

[mgol]

1. Install Node 0.11.13 on Windows 8.1
2. Checkout https://github.com/mzgol/grunt-check-dependencies
3. Run npm test

Effect: https://ci.appveyor.com/project/mzgol/grunt-check-dependencies/build/3/job/v5ik5b0f0b7nui91

This is because in this line:
https://github.com/mzgol/grunt-check-dependencies/blob/b904397b9ffc459e8a175d0026bd4063eb1f6676/test/spec.js#L37
grunt.config(['checkDependencies', 'ok', 'options']) returns undefined. grunt.config() in this place returns an empty object.

It works fine on OS X (and Linux, as seen in Travis) in both Node 0.10.29 and 0.11.13 and on Windows 8.1 on Node 0.10.29.

I don't currently have a convenient Windows setup to try to narrow the issue down but it seems there's a bug in this specific configuration.

Reported originally as gruntjs/grunt#1166

[indutny]

Thanks for reporting, but I couldn't accept this as a test case. Could you please reduce it to a chunk of javascript code that doesn't have any external dependencies?

[mgol]

I managed to set up a Windows VM with Node 0.11.13 and reproduce the issue there. What happens is the node_modules/grunt/lib/grunt/config.js file is evaluated twice in the failing case. I'll try to narrow it further down.

[mgol]

I have a test case. It consists of 3 files, all in the same directory. In Windows on Git Bash or on OS X if you invoke:

node -e "require('./main')"

you'll get:

file2 required
file1 required

whereas on Windows cmd you'll get:

file2 required
file1 required
file2 required

Files:

1. main.js:

var path = require('path');
require('./file2.js');
require(path.resolve('./file1.js'));
//require('./file1.js');

2. file1.js:

console.log('file1 required');
require('./file2.js');

3. file2.js:

console.log('file2 required');

Interestingly enough, if you uncomment the last line in main.js and comment out the last but one, it starts behaving correctly. It seems that using path.resolve messes it up.

[mgol]

The problem seems to boil down to require.resolve using lowercase drive letters and path.resolve using uppercase ones. In Node 0.10 require('./file') resolves the drive letter to uppercase C so they match; it's been changed in 0.11 apparently which causes cache mismatches and modules are loaded again.

[mgol]

Shouldn't this be already tested by https://github.com/joyent/node/blob/4f1782ef750fb171eb90a1d97b14e2ed3a8a165d/test/simple/test-require-resolve.js#L27-L28?

[mgol]

I wanted to narrow it down further and try to fix it myself but the Module constructor defined in file lib/module.js doesn't seem to be available to the outside so I can't effectively monkey-patch its methods in runtime and building Node on Windows isn't so straigtforward...

So I guess I'll leave you there.

[mgol]

@indutny Do you need anything else from me?

[indutny]

cc @orangemocha @piscisaureus

[orangemocha]

There's already a (rather old) PR to address this #6774