Blacken our code #1900
Closed
Blacken our code #1900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By doing this, we're basically making it impossible for changes from refack/GYP3 to be pulled over, so we'd need to be sure that we're committing to maintaining GYP here and having the canonical version. I'm fine with applying consistent style linting, it makes contributions much more straightforward, but this is a big step, so let's let this linger and see what others have to say. |
|
If we blacken both codebases, we will get really clean diffs. |
but lose the ability to cherry-pick isolated changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
Like #1899 but for Python code. Uses the Python Software Foundation's Black https://github.com/psf/black to format all Python code in the canonical way and adds a test to Travis CI to avoid any backsliding.