This repository was archived by the owner on Jul 6, 2018. It is now read-only.
http2: improve error handling and test cases #134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error handling from the binding layer was not very sophisticated. This changes things such that errors on generally synchronous APIs are thrown, while only errors that happen in async operations end up in error events. This still may need to evolve but this is closer to what it should be. Also, as much as possible, hide the details of NGHTTP2 specific errors using Node.js specific error codes and messages. There is still more to be done here.
|
@mcollina ... I'd like your thoughts on this. It may be better to push most of the errors to the error event rather than throw synchronously for everything except argument validation. This PR is currently a WIP towards making improvements... |
Ensure that session and stream methods work before connect
jasnell
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
jasnell
added a commit
that referenced
this pull request
May 18, 2017
PR-URL: #134 Reviewed-By: Matteo Collina <[email protected]>
|
Landed |
jasnell
added a commit
that referenced
this pull request
May 19, 2017
PR-URL: #134 Reviewed-By: Matteo Collina <[email protected]>
jasnell
added a commit
that referenced
this pull request
May 31, 2017
PR-URL: #134 Reviewed-By: Matteo Collina <[email protected]>
jasnell
added a commit
to jasnell/http2-1
that referenced
this pull request
Jun 22, 2017
PR-URL: nodejs#134 Reviewed-By: Matteo Collina <[email protected]>
jasnell
added a commit
to jasnell/http2-1
that referenced
this pull request
Jul 10, 2017
PR-URL: nodejs#134 Reviewed-By: Matteo Collina <[email protected]>
jasnell
added a commit
to jasnell/http2-1
that referenced
this pull request
Jul 14, 2017
PR-URL: nodejs#134 Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling throughout and make sure that
Http2SessionandHttp2Streammethods work before the client is fully connected, with reasonable error handling.Bunch of new test cases
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2