feat: provide escaped version of PRODUCT_DIR_ABS
#271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Node.js uses this in a C string, we should provide a version that escapes it as a C string.
cclauss
reviewed
Dec 2, 2024
cclauss
approved these changes
Dec 2, 2024
Co-authored-by: Christian Clauss <[email protected]>
|
Sorry, please add |
Co-authored-by: Christian Clauss <[email protected]>
|
@cclauss sure, done! 🙇♀️ |
anonrig
approved these changes
Dec 3, 2024
addaleax
added a commit
that referenced
this pull request
Dec 9, 2024
The review suggestion in #271 accidentally changed the type of `result` and broke this part.
addaleax
added a commit
that referenced
this pull request
Dec 9, 2024
The review suggestion in #271 accidentally changed the type of `result` and broke this part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Node.js uses this in a C string, we should provide a version that escapes it as a C string.
Needed by: nodejs/node#56111