jenkins: fix small bugs in trigger-jenkins-build #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Getting this out now to stop the bot from continually crashing... |
|
Good catch! I assume an unhandled exception handler that logged the error would have given us some hints about what caused the unexpected restarts? |
phillipj
added a commit
to phillipj/github-bot
that referenced
this pull request
Jun 9, 2018
Whenever unhandled errors are raised, it's especially important for us
to get some hints of what happened. In a perfect world these kinds of
errors shouldn't happen, but ofcourse they do for time to time..
The last time we had this kinds of error, there were no errors visible
in the logs, other than seeing that the bot process seemed to restart
more than usual.
While working in these changes, I found that the default unhandled
error handler in express.js, writes the error to stdout, not into the
log log files we've write through via bunyan.
With these changes in place we'll get something like this in the logs:
```
19:16:26.303Z FATAL bot: Unchaught exception, terminating bot process immediately
ReferenceError: invokingNoneExistentFunction is not defined
at Promise.resolve.then (/github-bot/app.js:47:31)
at process._tickCallback (internal/process/next_tick.js:109:7)
at Module.runMain (module.js:613:11)
at run (bootstrap_node.js:387:7)
at startup (bootstrap_node.js:153:9)
at bootstrap_node.js:500:3
```
Refs nodejs#174
phillipj
added a commit
that referenced
this pull request
Jun 9, 2018
#179) Whenever unhandled errors are raised, it's especially important for us to get some hints of what happened. In a perfect world these kinds of errors shouldn't happen, but ofcourse they do for time to time.. The last time we had this kinds of error, there were no errors visible in the logs, other than seeing that the bot process seemed to restart more than usual. While working in these changes, I found that the default unhandled error handler in express.js, writes the error to stdout, not into the log log files we've write through via bunyan. With these changes in place we'll get something like this in the logs: ``` 19:16:26.303Z FATAL bot: Unchaught exception, terminating bot process immediately ReferenceError: invokingNoneExistentFunction is not defined at Promise.resolve.then (/github-bot/app.js:47:31) at process._tickCallback (internal/process/next_tick.js:109:7) at Module.runMain (module.js:613:11) at run (bootstrap_node.js:387:7) at startup (bootstrap_node.js:153:9) at bootstrap_node.js:500:3 ``` Refs #174 /cc @nodejs/github-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.