Update architectures files #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterDaveHello
requested review from
chorrell,
Starefossen,
LaurentGoderre,
SimenB and
a team
chorrell
approved these changes
Nov 1, 2018
|
LGTM. Hopefully that's the last thing that needs fixing. |
|
It takes much time on manually generate the library/node file as we want to keep LTS versions not being changed, I wonder if we still need to do that for a month, I prefer to keep that for this and only this version. |
PeterDaveHello
added a commit
to PeterDaveHello/docker-node
that referenced
this pull request
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #887