chore: Remove old signing keys #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterDaveHello
requested changes
Jul 21, 2020
| A48C2BEE680E841632CD4E44F07496B3EB3C1762 | ||
| B9E2F5981AA6E0CD28160D9FF13993A75599653C | ||
| C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C |
There was a problem hiding this comment.
Not sure the reason to change the order here 🤔
There was a problem hiding this comment.
It might make it easier to keep in sync with the list of keys in https://github.com/nodejs/node/#release-keys (where it's ordered by the name of the releaser the key belongs to).
There was a problem hiding this comment.
Should be some script ideally that dumps from that repo, sorts and inserts somewhere in this repo for consumption
|
@PeterDaveHello there are no keys added, the new lines are from sorting them to match the upstream source Removed:
|
|
@nschonni you're right, just misunderstood because of the ordering, maybe can also mention that the next time ;) |
PeterDaveHello
approved these changes
Jul 22, 2020
PeterDaveHello
approved these changes
Jul 22, 2020
PeterDaveHello
added a commit
to PeterDaveHello/docker-node
that referenced
this pull request
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the images that would need these old keys are out of support, we should be able to drop them now to shrink the generated Dockerfiles a little.
I just copied the current ordering from https://github.com/nodejs/node/#release-keys along with @richardlau new key that is being PR'd to that file right now