Skip to content
This repository was archived by the owner on Aug 7, 2023. It is now read-only.
This repository was archived by the owner on Aug 7, 2023. It is now read-only.

Common questions at C&L events #86

@BridgeAR

Description

@BridgeAR

This issue is meant as a kind of FAQ for mentees and mentors.

Please add comments for things that you might encounter so others can look this up as well.

Questions:

  • How to make sure the code is covered without running make coverage.
    • A simple solution is to just add a console.log statement at the code point that should be reached and to check the console output.
  • How to get the test output from console.log() in the Node core tests?
    • Just run the code with ./node ./test/parallel/test-foo.js instead of python tools/test.py parallel/test-foo.js.
      If the test file has a "flags" comment at the top, start Node.js with those manually, e.g., ./node --expose-internals ./test/parallel/test-foo.js.
  • How to run a single test or all tests from a specific sub system?
    • Either use ./node relative-or-absolute-test-file-path.js or python tools/test.py subsystem/file-name.js for a single file or python tools/test.py -J subsystem for a whole subsystem or python tools/test.py -J glob
  • How to create a new test?
    • Check already existing tests. The test passes if the file executes without error. So just write the test as any other regular code.
  • What should be done with the pull request check marks if there is no documentation involved?
    • Please just mark the check mark as done or remove the entry if not applicable.
  • What should be done if make test shows failing tests on a local machine having the Nodejs master branch checked out without any changes?
    • Please check if there is an open issue that already summarizes the issue on your platform. If not, please open a new issue on the main Nodejs repository and copy the output in that issue, add all system information you have and under what circumstances the test(s) failed. If you are able to provide additional information to an existing issue, please do that as well.
  • The pull request got a "author ready" label but the code is not immediately merged. Why not?
    • We try to merge C&L PRs fast but for some PRs we'll want to make sure more collaborators got the chance to look at it. Therefore there are some rules in place how long a pull request has to be open before it may land. It also has to have a full CI run that has to be green so we are able to land it. So please be patient. If there is no activity for multiple days, just ask for reviews.
  • TBD...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions