ansible: don't assume the relative paths for staging & dist are the same #3947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
reviewed
Nov 4, 2024
Some non-mainline releases' src dirs differ from their dst dirs (i.e.
v8-canary builds upload to `/home/staging/nodejs/custom` and then are
promoted to `/home/dist/nodejs/v8-canary`. This wasn't being accounted
for when we promoted files from the `dist-staging` bucket to the
`dist-prod` bucket.
Signed-off-by: flakey5 <[email protected]>
flakey5
force-pushed
the
flakey5/20241104/fixes
branch
from
32b5eba to
f2078cb
Compare
targos
approved these changes
Nov 4, 2024
richardlau
approved these changes
Nov 4, 2024
Member
|
deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some non-mainline releases' src dirs differ from their dst dirs (i.e. v8-canary builds upload to
/home/staging/nodejs/customand then are promoted to/home/dist/nodejs/v8-canary. This wasn't being accounted for when we promoted files from thedist-stagingbucket to thedist-prodbucket.