Skip to content

ansible: add ninja-build to x64 V8 builders #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023
Merged

ansible: add ninja-build to x64 V8 builders #3305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ansible/inventory.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,9 +268,9 @@ hosts:
intel-ubuntu2204-x64-1:
ip: 92.51.196.114
build_test_v8: yes
is_benchmark: yes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this because I'm not sure if we need this set (the other benchmark machine doesn't set this) and the role is currently broken -- it tries to install packages from ansible/roles/benchmarking/vars/main.yml and fails to find

build/ansible/roles/benchmarking/vars/main.yml

Lines 11 to 13 in f45d157

- python-eventlet
- python-numpy
- python-requests
. Presumably these are available package differences after the upgrade to Ubuntu 22.04.

intel-ubuntu2204-x64-2:
ip: 92.51.196.115
build_test_v8: yes

- osuosl:
# secret for -1 was compromised, do not use -1 name
Expand Down
8 changes: 7 additions & 1 deletion ansible/roles/build-test-v8/tasks/partials/rhel8-x64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,17 @@
# Install packages for V8 builds.
#

# ninja-build on RHEL 8 is in the CodeReady Linux Builder repository.
- name: enable codeready-builder repository
community.general.rhsm_repository:
name: codeready-builder-for-rhel-8-x86_64-rpms
state: enabled

# V8 builds still require Python 2.
# Newer V8 builds require Python 3.8, or later.
- name: install packages required to build V8
ansible.builtin.dnf:
name: ['python2', 'python2-pip', 'python39']
name: ['ninja-build', 'python2', 'python2-pip', 'python39']
state: present
notify: package updated

Expand Down
10 changes: 10 additions & 0 deletions ansible/roles/build-test-v8/tasks/partials/ubuntu2204.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---

#
# Install packages for V8 builds.
#

- name: install packages required to build V8
ansible.builtin.apt:
name: ['ninja-build', 'python3-httplib2']
state: present