node-test-node-addon-api-new job hanging?

[BethGriggs]

It seems like this job is regularly hanging - previous runs have taken between 2-10minutes. The previous run took 7 hours+ and the current run is at 4+ hours.

https://ci.nodejs.org/job/node-test-node-addon-api-new/nodes=fedora-latest-x64/1617/

[BethGriggs]

The same test hang across multiple platforms - possibly caused by nodejs/node@689ab46?

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  Comparison {
+   message: 'Invalid argument',
+   name: 'Error'
-   message: 'Maximum BigInt size exceeded',
-   name: 'RangeError'
  }
    at test (/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/centos7-ppcle/node-addon-api/test/bigint.js:48:10)
    at Object.<anonymous> (/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/centos7-ppcle/node-addon-api/test/bigint.js:6:1)
    at Module._compile (internal/modules/cjs/loader.js:1215:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1235:10)
    at Module.load (internal/modules/cjs/loader.js:1064:32)
    at Function.Module._load (internal/modules/cjs/loader.js:959:14)
    at Module.require (internal/modules/cjs/loader.js:1104:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at /home/iojs/build/workspace/node-test-node-addon-api-new/nodes/centos7-ppcle/node-addon-api/test/index.js:96:5
    at Array.forEach (<anonymous>) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: Error: Invalid argument
      at getActual (assert.js:688:5)
      at Function.throws (assert.js:828:24)
      at test (/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/centos7-ppcle/node-addon-api/test/bigint.js:48:10)
      at Object.<anonymous> (/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/centos7-ppcle/node-addon-api/test/bigint.js:6:1)
      at Module._compile (internal/modules/cjs/loader.js:1215:30)
      at Object.Module._extensions..js (internal/modules/cjs/loader.js:1235:10)
      at Module.load (internal/modules/cjs/loader.js:1064:32)
      at Function.Module._load (internal/modules/cjs/loader.js:959:14)
      at Module.require (internal/modules/cjs/loader.js:1104:19)
      at require (internal/modules/cjs/helpers.js:72:18),
  expected: [Object],
  operator: 'throws'
}

ping @nodejs/addon-api

[BethGriggs]

Aborted https://ci.nodejs.org/job/node-test-node-addon-api-new/1616/ and https://ci.nodejs.org/job/node-test-node-addon-api-new/1617/ as they were both hanging.

[richardlau]

ping @nodejs/addon-api

Based on the team members listed on https://github.com/nodejs/node-addon-api maybe also ping @nodejs/n-api?

[BethGriggs]

Does it make sense to turn the timer off on that job until the hanging issue is resolved? I think it is configured to run daily.

[richardlau]

@nodejs/n-api-admins Are there any objections to enabling timeouts on the job to prevent hanging tests from tying up CI infrastructure?

[mhdawson]

I'll try to look today to see if its the BigInt change and if we need to update the tests.

[mhdawson]

Cancelled the current job

[mhdawson]

Started by removing 8.x from the tests as is has gone EOL and therefore we've landed some code that no longer works there.

[mhdawson]

Next will look at the test so that it accomodates the change in master.

[richardlau]

@mhdawson @nodejs/n-api-admins Any comments on adding a timeout to the node-test-node-addon-api-new build (#2131 (comment))?

I've also noticed that node-test-node-addon-api-new runs once a day on the sixth hour:

but it's also run once per day by node-test-node-addon-api-LTS versions on the third hour:

(e.g. for today https://ci.nodejs.org/job/node-test-node-addon-api-new/1625/ and https://ci.nodejs.org/job/node-test-node-addon-api-new/1623/ (via https://ci.nodejs.org/job/node-test-node-addon-api-LTS%20versions/617/))

Does master need to be tested twice a day?

[mhdawson]

PR to fix test: nodejs/node-addon-api#649

Believe it was also likely the cause of the hang.

[mhdawson]

Landed PR to fix test.

Updated the new job to not run on its own so we should now only test master once a day

Launched job to test across versions to confirm we are now good
https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/618/