access for @victorgomes to osx build bot

[MylesBorins]

They are chasing down the issues in nodejs/node#29493 and want to see if they can get a patch together to get V8 7.8 working on our build machines.

[sam-github]

@MylesBorins Is the criteria met?

• Does the scope and size of the need justify providing access.
• Is the individual a collaborator. If so then access should be allowed provided the first point is satisfied.
• Length and consistency of involvement with Node.js working groups and/or community.
• Consequences to the individual in case of misbehaviour. For example, would they potentially lose their job if they were reported as mis-behaving to their employer ? Would being banned from involvement in the Node.js community negatively affect them personally in some other way ?
• Are there collaborators who work with the individual and can vouch for them.

From https://github.com/nodejs/build/blob/master/doc/process/special_access_to_build_resources.md

[sam-github]

@victorgomes

[MylesBorins]

• Does the scope and size of the need justify providing access.

This is to unblock the landing of V8 7.8 for Node.js 13. The work should be completed in less than a week.

• Is the individual a collaborator. If so then access should be allowed provided the first point is satisfied.

They Are not

• Length and consistency of involvement with Node.js working groups and/or community.

They are a a member of the V8 team, who was requested to handle this problem after the TSC meeting we had yesterday

• Consequences to the individual in case of misbehaviour. For example, would they potentially lose their job if they were reported as mis-behaving to their employer ? Would being banned from involvement in the Node.js community negatively affect them personally in some other way ?

They are an employee of Google. Misbehavior would be a risk to their employment.

• Are there collaborators who work with the individual and can vouch for them.

I do

[sam-github]

That's strong enough a case I would add access immediately, except I don't have any idea how to access the OS X CI machines, and can't find any docs on them in nodejs/build. ssh didn't work, but that's not a surprise.

@nodejs/platform-macos @nodejs/build Anyone have any ideas?

[mhdawson]

@sam-github ssh should work, let me try.

[mhdawson]

It works for our mac stadium 10.10 machines with this entry in the ssh config file

Host test-macstadium-macos10.10-x64-1
  HostName 207.254.58.162
  Port 10005
  IdentityFile ~/.ssh/nodejs_build_test
  User administrator

I've tried with test-requireio-osx1010-x64-1, which I think the config entry should be the following based on: https://github.com/nodejs/build/pull/1890/files.

Host test-requireio-osx1010-x64-1
  HostName 192.168.2.210
  IdentityFile ~/.ssh/nodejs_build_test
  User iojs
  ProxyCommand ssh -i ~/.ssh/nodejs_build_test -p 2222 jump@vagg-arm.nodejs.org nc -q0 %h %p

@rvagg I still can't connect with this entry, can you see what I've got wrong?

user1@user1-lbuntu:~/.ssh$ ssh test-requireio-osx1010-x64-1
ssh_exchange_identification: Connection closed by remote host

[mhdawson]

@MylesBorins was test-requireio-osx1010-x64-1 chosen for a specific reason or would be ok ? test-macstadium-macos10.10-x64-1

[sam-github]

Like @mhdawson, I can ssh into test-macstadium-macos10.10-x64-1, but not test-requireio-osx1010-x64-1:

ssh -vvv test-requireio-osx1010-x64-1
OpenSSH_7.9p1 Ubuntu-10, OpenSSL 1.1.1b  26 Feb 2019
debug1: Reading configuration data /home/sam/.ssh/config
debug1: /home/sam/.ssh/config line 17: Applying options for *
debug1: /home/sam/.ssh/config line 802: Applying options for test-requireio-osx1010-x64-1
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: /etc/ssh/ssh_config line 19: Applying options for *
debug2: resolve_canonicalize: hostname 192.168.2.210 is address
debug1: Executing proxy command: exec ssh -i ~/.ssh/ansible_ssh_private_key_file -p 2222 jump@vagg-arm.nodejs.org nc -q0 192.168.2.210 22
debug1: identity file /home/sam/.ssh/id_rsa type 0
debug1: identity file /home/sam/.ssh/id_rsa-cert type -1
debug1: identity file /home/sam/.ssh/nodejs_build_test type -1
debug1: identity file /home/sam/.ssh/nodejs_build_test-cert type -1
debug1: Local version string SSH-2.0-OpenSSH_7.9p1 Ubuntu-10
ssh_exchange_identification: Connection closed by remote host

[MylesBorins]

Any Mac machine works

…

On Thu, Sep 19, 2019, 6:39 PM Sam Roberts ***@***.***> wrote: Like @mhdawson <https://github.com/mhdawson>, I can ssh into test-macstadium-macos10.10-x64-1, but not test-requireio-osx1010-x64-1: ssh -vvv test-requireio-osx1010-x64-1 OpenSSH_7.9p1 Ubuntu-10, OpenSSL 1.1.1b 26 Feb 2019 debug1: Reading configuration data /home/sam/.ssh/config debug1: /home/sam/.ssh/config line 17: Applying options for * debug1: /home/sam/.ssh/config line 802: Applying options for test-requireio-osx1010-x64-1 debug1: Reading configuration data /etc/ssh/ssh_config debug1: /etc/ssh/ssh_config line 19: Applying options for * debug2: resolve_canonicalize: hostname 192.168.2.210 is address debug1: Executing proxy command: exec ssh -i ~/.ssh/ansible_ssh_private_key_file -p 2222 ***@***.*** nc -q0 192.168.2.210 22 debug1: identity file /home/sam/.ssh/id_rsa type 0 debug1: identity file /home/sam/.ssh/id_rsa-cert type -1 debug1: identity file /home/sam/.ssh/nodejs_build_test type -1 debug1: identity file /home/sam/.ssh/nodejs_build_test-cert type -1 debug1: Local version string SSH-2.0-OpenSSH_7.9p1 Ubuntu-10 ssh_exchange_identification: Connection closed by remote host — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1920?email_source=notifications&email_token=AADZYV3QFUPXLKJPY2AR2GDQKP5S7A5CNFSM4IYL2BPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7FAW2Y#issuecomment-533334891>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADZYV2CSEQTPXMSYIXF6KTQKP5S7ANCNFSM4IYL2BPA> .

[sam-github]

@victorgomes which of your keys would you like me to use? there are three at https://github.com/victorgomes.keys

[victorgomes]

@sam-github I will use the last ssh key (ending with oyUAw==).

[rvagg]

Sorry, the requireio one is intentionally offline. Can be put back into service if needed but the macstadium ones seem to be going well for us.

[Trott]

Totally-unnecessary pile-on +1 from me.

[sam-github]

@victorgomes use this config,with identity replaced with whatever yours is:

Host test-macstadium-macos10.10-x64-1 
  HostName 207.254.58.162
  IdentityFile ~/.ssh/nodejs_build_test
  User administrator
  Port 10005

Ping here when you are done and someone will remove your key (or you can remove the key then close this).

[victorgomes]

@sam-github Thanks. I will tell you when we're done.