fix: socket variable testing for undefined

[joamag]

Avoid issue where socket event was not triggered and local socket variable is not defined. This issue is reproducible only using deno.

Purpose

#1725

Changes

Adds undefined testing to socket variable, protecting it from TypeError.

---

• fix Deno process crashes while using node-fetch 2.x.x #1725

[joamag]

@jimmywarting do you think you can merge this one? It's a simple undefined validation 🙏

[jimmywarting]

	request.on('response', response => {
		const {headers} = response;
		if (headers['transfer-encoding'] === 'chunked' && !headers['content-length']) {
			response.once('close', hadError => {
				// if for some reason the 'socket' event was not triggered
				// for the request (happens in deno) avoids `TypeError`
				if (socket === undefined) {
					return;
				}

				// if a data listener is still present we didn't end cleanly
				const hasDataListener = socket.listenerCount('data') > 0;

				if (hasDataListener && !hadError) {
					const err = new Error('Premature close');
					err.code = 'ERR_STREAM_PREMATURE_CLOSE';
					errorCallback(err);
				}
			});
		}
	});

don't we still want to handle close callback at what is at the bottom?
aka:

				if (hasDataListener && !hadError) {
					const err = new Error('Premature close');
					err.code = 'ERR_STREAM_PREMATURE_CLOSE';
					errorCallback(err);
				}

maybe would be better to just do:

				// if for some reason the 'socket' event was not triggered
				// for the request (happens in deno) avoids `TypeError`
				if (socket) {
				    // if a data listener is still present we didn't end cleanly
				    const hasDataListener = socket.listenerCount('data') > 0;
				}

[joamag]

	request.on('response', response => {
		const {headers} = response;
		if (headers['transfer-encoding'] === 'chunked' && !headers['content-length']) {
			response.once('close', hadError => {
				// if for some reason the 'socket' event was not triggered
				// for the request (happens in deno) avoids `TypeError`
				if (socket === undefined) {
					return;
				}

				// if a data listener is still present we didn't end cleanly
				const hasDataListener = socket.listenerCount('data') > 0;

				if (hasDataListener && !hadError) {
					const err = new Error('Premature close');
					err.code = 'ERR_STREAM_PREMATURE_CLOSE';
					errorCallback(err);
				}
			});
		}
	});

don't we still want to handle close callback at what is at the bottom? aka:

				if (hasDataListener && !hadError) {
					const err = new Error('Premature close');
					err.code = 'ERR_STREAM_PREMATURE_CLOSE';
					errorCallback(err);
				}

maybe would be better to just do:

				// if for some reason the 'socket' event was not triggered
				// for the request (happens in deno) avoids `TypeError`
				if (socket) {
				    // if a data listener is still present we didn't end cleanly
				    const hasDataListener = socket.listenerCount('data') > 0;
				}

Yes it makes more sense.
It's done 👍

[joamag]

@jimmywarting should be ready for merge 😀

[joamag]

@LinusU Can you the this PR, it would be super useful to have this one merged :) 🙏

[github-actions]

🎉 This PR is included in version 2.6.12 🎉

The release is available on:

• npm package (@release-2.x dist-tag)
• GitHub release

Your semantic-release bot 📦🚀