Skip to content

prefeature: generalizes use of NonActionableError.rethrow #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 30, 2025
Merged

prefeature: generalizes use of NonActionableError.rethrow #280

merged 5 commits into from
May 30, 2025

Conversation

bjacobgordon
Copy link
Collaborator

@bjacobgordon bjacobgordon commented May 30, 2025 •
edited
Loading

  • messaging for rethrows should be contextual
  • before, it was hard coded within the NonActionableError model so we weren't using it anywhere else

@bjacobgordon bjacobgordon force-pushed the refactor-library-genealizes-use-of-NonActionableError-rethrow branch from 0dbc3b4 to 9a69898 Compare May 30, 2025 13:49
@bjacobgordon bjacobgordon mentioned this pull request May 30, 2025
Closed
@bjacobgordon bjacobgordon force-pushed the refactor-library-genealizes-use-of-NonActionableError-rethrow branch 2 times, most recently from 654e1aa to 6793e31 Compare May 30, 2025 16:06
@bjacobgordon bjacobgordon force-pushed the refactor-library-genealizes-use-of-NonActionableError-rethrow branch from 6793e31 to 6e2ffc7 Compare May 30, 2025 17:03
@bjacobgordon bjacobgordon changed the title refactor(library): generalizes use of NonActionableError.rethrow in Attempt utility prefeature: generalizes use of NonActionableError.rethrow May 30, 2025
@bjacobgordon bjacobgordon merged commit 073cc3b into nod-ai:integration May 30, 2025
3 checks passed
@bjacobgordon bjacobgordon deleted the refactor-library-genealizes-use-of-NonActionableError-rethrow branch May 30, 2025 17:09
@bjacobgordon bjacobgordon mentioned this pull request Jun 3, 2025
Closed
@bjacobgordon bjacobgordon linked an issue Jun 3, 2025 that may be closed by this pull request
prefeature: replace default error propagation with linter-enforceable type-safe variety #303
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
prefeature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prefeature: replace default error propagation with linter-enforceable type-safe variety
1 participant
@bjacobgordon