firefox: Add note for non-nixos support with MOZ_LEGACY_PROFILES
#8343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: nix-community#6170. Firefox, by default, will attempt to migrate the `profiles.ini` file to also include install information. If the user wishes to not have home-manager install Firefox but have it manage their profiles, this causes an error when it tries to write that file. This can be mitigated by setting `MOZ_LEGACY_PROFILES` (as the wrapped nix packages do), which disables this migration, so call that out in the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #6170. Firefox, by default, will attempt to migrate the
profiles.inifile to also include install information. If the user wishes to not have home-manager install Firefox but have it manage their profiles, this causes an error when it tries to write that file.This can be mitigated by setting
MOZ_LEGACY_PROFILES(as the wrapped nix packages do), which disables this migration, so call that out in the documentation.I considered having
MOZ_LEGACY_PROFILESbe set automatically whenpackage == null, but updating the environment like that seems kind of rude and makes assumptions as to what the user is likely doing.Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example. (Not required)
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.