alacritty: create appropriate import key for theme based on version #8301
Conversation
Both `general.import` and `import` keys were being created to import the theme despite the version check. This fixes it so only the appropriate key is created based on Alacritty version.
| general.import = lib.mkIf (lib.versionAtLeast cfg.package.version "0.14") [ theme ]; | ||
| import = lib.mkIf (lib.versionOlder cfg.package.version "0.14") [ theme ]; | ||
| }; | ||
| lib.mkIf (cfg.theme != null) ( |
There was a problem hiding this comment.
Could you update tests to verify the expected behavior of the change. So we can see the expected toml for pre 0.14 and post 0.14.
Also looks like a simpler solution would have been to include the import key in the guarded part no? We keep mkIf benefits and just don't create any of the key/values unless version matches.
There was a problem hiding this comment.
hi @khaneliman I will try to learn how to do the thing you suggested and also how to create a test for this. I have less than rudimentary understanding of Nix so it might take me a long time to find time and figure it out. I am happy to take any pointers/links to examples but have no expectations in having my hand held. Thanks for the suggestions.
There was a problem hiding this comment.
@khaneliman maybe I should be using lib.mkMerge to preserve the benefits of lib.mkIf? If that's not the right path, please let me know. I'll learn about updating the tests and give it a go. I can verify now that it will generate only one attribute based on the version number specified, which is the bug being fixed. Thanks again for suggestion.
There was a problem hiding this comment.
We have various examples in the repo of where the cfg.packge version is checked to determine something. I'd look for something that uses mkStubPackage with a version = "" that mocks up a specific version of a package to test version logic in a module.
2 participants
Description
Both
general.importandimportkeys were being created to import the theme despite the version check. This fixes it so only the appropriate key is created based on Alacritty version.Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.[-] Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Ran the following:
nix-shell --pure tests tests/modules/programs/alacrittyTest cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.