home-environment: require home.uid for stateVersion >= 26.05 #8292
+59
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc. @teto |
Make home.uid mandatory for users with stateVersion 26.05 or later. This follows up on the addition of home.uid in a521eab, addressing the discussion about making the option required. When using Home Manager as a NixOS or nix-darwin module, home.uid is automatically set from users.users.<name>.uid when that option is defined. For standalone usage or when the system user has no explicit UID, users must now set home.uid directly.
lovesegfault
force-pushed
the
require-uid
branch
from
71cdb94 to
de2d5cd
Compare
ambroisie
reviewed
Dec 5, 2025
Contributor
ambroisie
left a comment
ambroisie
left a comment
There was a problem hiding this comment.
Why do we want it to be required? I can see why some users would want to use it in their downstream configuration (one example that comes to mind is to set the secrets' path when using agenix, as mentioned in #8284 (comment)). However I don't think home-manager itself should require it, and most use-cases for knowing the UID can actually just rely on e.g: XDG_RUNTIME_DIR and other such values.
Collaborator
|
Making this significantly raises the bar to setup home-manager IMO so it would be good to know the benefits before making it mandatory. If benefits are small maybe it's simpler for users to specialcase modules depending on wether the value is set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #8284 addressing the discussion about making
home.uidmandatory.This PR makes
home.uidrequired for users withstateVersion26.05 or laterWho is affected
Users with
stateVersion >= 26.05who don't havehome.uidset:home.uidmanuallyusers.users.<name>.uid- The module only auto-discovers whenuidis explicitly set in the system config. Users relying on auto-assigned UIDs must either:users.users.<name>.uidexplicitly in their NixOS/nix-darwin config, ORhome.uiddirectly in their home-manager configChecklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.