Skip to content

Conversation

ErrorTeaPot
Copy link

Description

I am adding a Ghidra module. I have ported the nixpkgs one to home-manager with some changes for user-level compatibility.

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt-rfc-style deadnix keep-sorted --run treefmt.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@github-actions github-actions bot added the git label Jul 17, 2025
@ErrorTeaPot
Copy link
Author

Quick note regarding the written tests, I don't know how to handle dynamic nix store paths in tests.
The gdb option is adding a python script for gdb which contains nix store paths.

The CI on home-manager reported duplicates in maintainers.nix, I have
removed them to pass the test.
@ErrorTeaPot
Copy link
Author

The CI was mentionning 2 users that were duplicates, I have removed them in the last commit to prevent this problem.

@ErrorTeaPot
Copy link
Author

Even with myself added as a maintainer I still have the 2 CI tests that do not pass, it that normal ?

@khaneliman
Copy link
Collaborator

khaneliman commented Jul 25, 2025

Even with myself added as a maintainer I still have the 2 CI tests that do not pass, it that normal ?

 error: undefined variable 'ErrorTeaPot'
       at /nix/store/c0d9ia0vxrrs5m7amydymv28cb3h1gm4-source/modules/programs/ghidra.nix:44:46:
           43|
           44|   meta.maintainers = with lib.maintainers; [ ErrorTeaPot ];
             |                                              ^
           45| }

Looks like you need to use lib.hm.maintainers we don't have the hm maintainers in the same namespace.

@ErrorTeaPot
Copy link
Author

Even with myself added as a maintainer I still have the 2 CI tests that do not pass, it that normal ?

 error: undefined variable 'ErrorTeaPot'
       at /nix/store/c0d9ia0vxrrs5m7amydymv28cb3h1gm4-source/modules/programs/ghidra.nix:44:46:
           43|
           44|   meta.maintainers = with lib.maintainers; [ ErrorTeaPot ];
             |                                              ^
           45| }

Looks like you need to use lib.hm.maintainers we don't have the hm maintainers in the same namespace.

Do I need to remove myself in the other maintainers file I have already edited ?

@khaneliman
Copy link
Collaborator

No, it's throwing an error because you are accessing the nixpkgs maintainers list but aren't in it. You just need to reference your name from the 'lib.hm.maintainers' set

@ErrorTeaPot
Copy link
Author

No, it's throwing an error because you are accessing the nixpkgs maintainers list but aren't in it. You just need to reference your name from the 'lib.hm.maintainers' set

I have patched the maintainers problem

@khaneliman
Copy link
Collaborator

Can you try cleaning up commits and rebasing on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants