-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add ghidra module #7491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add ghidra module #7491
Conversation
Porting the nixpkgs ghidra module to home-manager, with some changes to work at user level
…ger into ghidra_option_init
Quick note regarding the written tests, I don't know how to handle dynamic nix store paths in tests. |
The CI on home-manager reported duplicates in maintainers.nix, I have removed them to pass the test.
The CI was mentionning 2 users that were duplicates, I have removed them in the last commit to prevent this problem. |
Even with myself added as a maintainer I still have the 2 CI tests that do not pass, it that normal ? |
error: undefined variable 'ErrorTeaPot'
at /nix/store/c0d9ia0vxrrs5m7amydymv28cb3h1gm4-source/modules/programs/ghidra.nix:44:46:
43|
44| meta.maintainers = with lib.maintainers; [ ErrorTeaPot ];
| ^
45| } Looks like you need to use |
Do I need to remove myself in the other maintainers file I have already edited ? |
No, it's throwing an error because you are accessing the nixpkgs maintainers list but aren't in it. You just need to reference your name from the 'lib.hm.maintainers' set |
I have patched the maintainers problem |
Can you try cleaning up commits and rebasing on master. |
Description
I am adding a Ghidra module. I have ported the nixpkgs one to home-manager with some changes for user-level compatibility.
Checklist
Change is backwards compatible.
Code formatted with
nix fmt
ornix-shell -p treefmt nixfmt-rfc-style deadnix keep-sorted --run treefmt
.Code tested through
nix-shell --pure tests -A run.all
or
nix build --reference-lock-file flake.lock ./tests#test-all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC