Open
Conversation
Add an `include-decorations` boolean flag to `screenshot-window` that renders the window with its compositor-drawn decorations (border, focus ring, shadow, rounded corner clipping) and alpha transparency. When enabled, the screenshot is rendered through the tile's full decoration pipeline rather than just the bare window surface. This produces a PNG with the window as it appears on screen, including transparent regions behind rounded corners and drop shadows. The option defaults to false, preserving existing behavior. Ref: niri-wm#3283 Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
I think instead of a flag, it should be a separate action screenshot-tile. We have the window-tile distinction elsewhere in IPC so it would be consistent. |
Per review feedback from YaLTeR: use a separate `screenshot-tile` action rather than an `include-decorations` flag on `screenshot-window`. This is consistent with the existing window-tile distinction in the IPC (e.g. `tile_size` vs `window_size` in window info). Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bennypowers
changed the title
Author
|
Пожалуйста |
Sempyos
added
area:config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
screenshot-tileaction that captures a window with its compositor-drawn decorations (border, focus ring, shadow, rounded corner clipping) and alpha transparencyscreenshot-windowaction's options (write-to-disk,show-pointer,--id,path)tile_sizevswindow_size)Usage
Config keybind:
IPC:
Test plan
screenshot-windowbehavior is unchangedscreenshot-tileincludes border when border is configuredscreenshot-tileincludes focus ring for focused windowsscreenshot-tileincludes shadow when shadow is enabledscreenshot-tileincludes rounded corner clipping with alpha transparencyscreenshot-tile --idvariant worksRef: #3283